New issue
Advanced search Search tips

Issue 788036 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove Stars.PromoActions histogram

Project Member Reported by jlebel@chromium.org, Nov 23 2017

Issue description

Replaced with:
 + Signin_Impression_FromBookmarkManager
 + MobileSignInPromo.BookmarkManager.ImpressionsTilXButton
 + MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButtons
 + MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss
 

Comment 1 by jlebel@chromium.org, Nov 23 2017

Labels: Hotlist-Polish

Comment 2 by jlebel@chromium.org, Nov 23 2017

Status: Started (was: Assigned)

Comment 3 by jlebel@chromium.org, Nov 23 2017

Cc: ew...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c9d54c11c470349b1f08ec61e666519f6d5829

commit 66c9d54c11c470349b1f08ec61e666519f6d5829
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Nov 23 14:16:58 2017

[iOS][Signin] Removing Stars.PromoActions histogram

Replaced with:
 + Signin_Impression_FromBookmarkManager
 + MobileSignInPromo.BookmarkManager.ImpressionsTilXButton
 + MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButtons
 + MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss

Bug:  788036 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3c6c4f08dc28c7ea1c0e8e0d27b6029f478c8f3a
Reviewed-on: https://chromium-review.googlesource.com/786238
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518926}
[modify] https://crrev.com/66c9d54c11c470349b1f08ec61e666519f6d5829/ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm

Comment 5 by jlebel@chromium.org, Nov 23 2017

Status: Fixed (was: Started)

Sign in to add a comment