Harmony - update TeleportWarningDialog |
|||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/TeleportWarningDialog#%2FScreenshot%202017-11-13%20at%2015.45.30.png%3Fz=width&c=show for screenshot and required changes.
,
Nov 23 2017
,
Nov 23 2017
,
Feb 28 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/941612 generates the attached dialog. Please take a look and let me know if it's sufficiently harmonious.
,
Apr 20 2018
- Remove close-x - "Don't show me again" (no punctuation)
,
Apr 20 2018
Correction: "Don't show again" (no punctuation)
,
Apr 30 2018
LGTM
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c214601b49743fdce695fb4b01dbb92aaa69b051 commit c214601b49743fdce695fb4b01dbb92aaa69b051 Author: glevin <glevin@chromium.org> Date: Tue May 01 18:40:15 2018 Harmonize TeleportWarningDialog As per crbug.com/788027 Comments 1,6,7: - Update checkbox text to "Don't show again" - Move "Don't show" checkbox to content area - Consolidate text into one paragraph - Change title text to "Warning: Experimental feature" - Remove X (Close) button from upper right window to <account>". Verify that dialog is Harmonious. Bug: 788027 Test: Open two multi-profiles, right-click on a window, select "Move Change-Id: Ia50d338271349d47a947b6d7c9e3a9bc13ade44f Reviewed-on: https://chromium-review.googlesource.com/941612 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555121} [modify] https://crrev.com/c214601b49743fdce695fb4b01dbb92aaa69b051/ash/ash_strings.grd [modify] https://crrev.com/c214601b49743fdce695fb4b01dbb92aaa69b051/ash/session/teleport_warning_dialog.cc [modify] https://crrev.com/c214601b49743fdce695fb4b01dbb92aaa69b051/ash/session/teleport_warning_dialog.h
,
May 2 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by x...@chromium.org
, Nov 23 2017