Harmony - update SessionAbortedDialog |
|||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/SessionAbortedDialog#%2FScreenshot%202017-11-13%20at%2015.38.49.png%3Fz=width&c=show for screenshot and required changes.
,
Nov 23 2017
,
Nov 23 2017
,
Feb 28 2018
,
Mar 1 2018
,
Mar 1 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/944258 generates the attached dialog. Please take a look and let me know if it's sufficiently harmonious.
,
Apr 10 2018
Updated with --enable-features=SecondaryUiMd on
,
Apr 20 2018
- remove the close x button - add a CANCEL button to the left of the default SIGN OUT button - What's determining the width of this dialog? 448px would be preferred - remove the line break after email address so that "All users..." runs on the same baseline.
,
Apr 20 2018
,
Apr 23 2018
bettes@ - Before I add the CANCEL button... it has the same effect as the SIGN OUT button. This dialog is not giving the user a choice... they must sign out. Should we still add two buttons, even if they do the same thing?
,
Apr 30 2018
Thanks for the clarification. In that case, we should remove the 'close-x' button. The below requests still apply: - remove the close x button - What's determining the width of this dialog? 448px would be preferred - remove the line break after email address so that "All users..." runs on the same baseline.
,
May 1 2018
Here's the latest version, updated as per Comment 11. bettes@ - How does this look?
,
May 14 2018
LGTM
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/454c40151b05d71a62829c1b5bdb82140116f1c0 commit 454c40151b05d71a62829c1b5bdb82140116f1c0 Author: glevin <glevin@chromium.org> Date: Mon May 14 14:46:17 2018 Harmonize SessionAbortedDialog As per crbug.com/788026 Comments 1,11: - Change title text - Consolidate text into one paragraph - Remove excess whitespace near bottom - Width = 448px - Remove X (Close) button from upper right Bug: 788026 Test: Set whatever policy is needed to disallow multi-signin from an account, try signing in from that account, observe Harmonious dialog. Change-Id: I1b5f2d2bf3ae092a28aa8ee48069cfead7c1559d Reviewed-on: https://chromium-review.googlesource.com/944258 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558302} [modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/ash_strings.grd [modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/session/session_aborted_dialog.cc [modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/session/session_aborted_dialog.h
,
May 14 2018
,
Jun 7 2018
Glevin@, apologies for not catching this before, but is it possible to update the body text string to: "Your organization doesn't allow multiple sign-ins. To change accounts, sign out." Since this is hitting 69, I assume we have enough time for the change and localization?
,
Jun 7 2018
Implementation deck with comments: https://docs.google.com/presentation/d/19yQuvKqmWPxe8TloAQ_5C12FV6v9eQ3qIFDXXuF10G8/edit#slide=id.g3b31c5d673_0_19
,
Jun 7 2018
The version in the deck is going out in M-68 (it's too late for a string change there). I can get your latest version in M-69.
,
Jul 12
+JonAnn |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by x...@chromium.org
, Nov 23 2017