New issue
Advanced search Search tips

Issue 788026 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 783540



Sign in to add a comment

Harmony - update SessionAbortedDialog

Project Member Reported by x...@chromium.org, Nov 23 2017

Issue description

Comment 1 by x...@chromium.org, Nov 23 2017

Blocking: 630357

Comment 2 by tapted@chromium.org, Nov 23 2017

Blocking: -630357

Comment 3 by tapted@chromium.org, Nov 23 2017

Blocking: 783540

Comment 4 by glevin@chromium.org, Feb 28 2018

Owner: glevin@chromium.org
Status: Started (was: Untriaged)
Cc: est...@chromium.org
 Issue 766395  has been merged into this issue.
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/944258 generates the attached dialog.  Please take a look and let me know if it's sufficiently harmonious.
hd_sessionabort_v1.png
10.4 KB View Download

Comment 7 by glevin@chromium.org, Apr 10 2018

Updated with --enable-features=SecondaryUiMd on
hd_sessionabort_v2.png
9.4 KB View Download

Comment 8 by bettes@chromium.org, Apr 20 2018

- remove the close x button
- add a CANCEL button to the left of the default SIGN OUT button
- What's determining the width of this dialog? 448px would be preferred
- remove the line break after email address so that "All users..." runs on the same baseline. 

Comment 9 by bettes@chromium.org, Apr 20 2018

Screen Shot 2018-04-20 at 3.57.40 PM.png
11.0 KB View Download
bettes@ - Before I add the CANCEL button... it has the same effect as the SIGN OUT button.  This dialog is not giving the user a choice... they must sign out.  Should we still add two buttons, even if they do the same thing?
Thanks for the clarification. In that case, we should remove the 'close-x' button. The below requests still apply: 

- remove the close x button
- What's determining the width of this dialog? 448px would be preferred
- remove the line break after email address so that "All users..." runs on the same baseline. 
Here's the latest version, updated as per Comment 11.
bettes@ - How does this look?
hd_sessionabort_v3.png
8.5 KB View Download
LGTM
Project Member

Comment 14 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454c40151b05d71a62829c1b5bdb82140116f1c0

commit 454c40151b05d71a62829c1b5bdb82140116f1c0
Author: glevin <glevin@chromium.org>
Date: Mon May 14 14:46:17 2018

Harmonize SessionAbortedDialog

As per crbug.com/788026 Comments 1,11:
- Change title text
- Consolidate text into one paragraph
- Remove excess whitespace near bottom
- Width = 448px
- Remove X (Close) button from upper right

Bug: 788026
Test: Set whatever policy is needed to disallow multi-signin from an
account, try signing in from that account, observe Harmonious dialog.

Change-Id: I1b5f2d2bf3ae092a28aa8ee48069cfead7c1559d
Reviewed-on: https://chromium-review.googlesource.com/944258
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558302}
[modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/ash_strings.grd
[modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/session/session_aborted_dialog.cc
[modify] https://crrev.com/454c40151b05d71a62829c1b5bdb82140116f1c0/ash/session/session_aborted_dialog.h

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Glevin@, apologies for not catching this before, but is it possible to update the body text string to: 

"Your organization doesn't allow multiple sign-ins. To change accounts, sign out."

Since this is hitting 69, I assume we have enough time for the change and localization? 

The version in the deck is going out in M-68 (it's too late for a string change there).  I can get your latest version in M-69.
Cc: jon...@chromium.org
+JonAnn

Sign in to add a comment