New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788025 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 783540



Sign in to add a comment

Harmony - update PlatformVerificationDialog

Project Member Reported by x...@chromium.org, Nov 23 2017

Issue description

Comment 1 by x...@chromium.org, Nov 23 2017

Blocking: 630357

Comment 2 by tapted@chromium.org, Nov 23 2017

Blocking: -630357

Comment 3 by tapted@chromium.org, Nov 23 2017

Blocking: 783540
Owner: glevin@chromium.org
Status: Started (was: Untriaged)
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/946907 generates the attached dialog.  Please take a look and let me know if it's sufficiently harmonious.
hd_platformverification_v1.png
12.7 KB View Download
Updated with --enable-features=SecondaryUiMd on
hd_platformverification_v2.png
10.8 KB View Download

Comment 6 Deleted

Comment 7 by bettes@chromium.org, Apr 20 2018

This reads as a permission request and really shouldn't be a centered, modal dialog. I presume any action taken here can be edited in the page info dialog, thus this should really be a popover dialog that's anchored to the security lock like Location Request (attached). 


At the very least, remove the close-x button. Modal dialogs should never have a close-x https://docs.google.com/presentation/d/1DhtL7baUPOx-r0DS3kHOAmFhcVCD8KvrR0K4tWGxxAs/edit?ts=59fb90b1#slide=id.g28286f72b7_0_206




Comment 8 by bettes@chromium.org, Apr 20 2018

Screen Shot 2018-04-20 at 4.09.38 PM.png
21.4 KB View Download

Comment 9 by glevin@chromium.org, Apr 26 2018

As shown in this screenshot, the dialog is anchored to the omnibox.  It's also not modal- while the dialog is up, you can switch to another application or tab, or navigate away from the dialog-displaying page (via Back / Forward buttons or omnibox); navigating away dismisses the dialog.

Also, as omrilio@ noted in a comment in the mocks:
  "X allows users to escape rather than forcing them to read and understand. Any reason not to keep it?"
That is, X is a valid third option: "Don't make any permanent decision about this right now".  Given this, is it still preferable to remove the Close-X button?
hd_platformverification_v3.png
21.6 KB View Download
Re:, the string, I believe the platform verification string should align with the newly rewritten protected content permission string:

[site] wants to 
[icon] Check if you're eligible to play higher quality or offline content. Your device's identity will be verified by Google.

Please check with hbengali@ to verify. 
Cc: glevin@chromium.org
Labels: -M-65 M-68
Owner: hbengali@chromium.org
hbengali@ - We're updating the style of this dialog to conform with Harmony specs.  I assume we'll also want this Chrome OS version to somewhat match the Android version being worked on in Issue 721969.  There haven't been any updates on that bug in a month.  Could you advise on how I should proceed with this update?  Has a final version of the other dialog been settled on yet?  Do you have a screenshot?  We're targeting this at M-68, so if there's no final version for the other yet, do you have any objections to me just updating the style here, and dealing with the string update at a later time?  Thanks!
P.S.- Any thoughts about whether the X-Close button should be kept (see Comment #9) or removed (as is typical of Harmony dialogs)?

P.P.S.- Note that the Chrome OS dialog will want to keep the [?] (Learn more) button (see Comment #9 screenshot), so any updated design will have to accommodate that.
Cc: shihuis@chromium.org
Cc: hbengali@chromium.org
Owner: glevin@chromium.org
With branch coming, and absent final judgments from UX, I've submitted a CL for review (https://chromium-review.googlesource.com/c/chromium/src/+/946907) with a string that reads:
  "<example.com> wants to play protected content. Your device’s identity will be verified by Google."
matching IDS_PROTECTED_MEDIA_IDENTIFIER_INFOBAR_TEXT as per Issue 721969, and with the X-Close button left in (as per Omri's and my judgement).  Here's a screenshot of the latest version.
hd_platformverification_v4.png
19.7 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1372e881962fd4356de525260f2d806dcfc8e0d7

commit 1372e881962fd4356de525260f2d806dcfc8e0d7
Author: glevin <glevin@chromium.org>
Date: Thu May 24 18:30:52 2018

Harmonize PlatformVerificationDialog

As per  crbug.com/788025  and various other discussions:
- Replace "Learn more" link with (?) button
  - Button has a11y text and is Tab stop
- Update text to match crbug.com/721969
- Width = 448px
- At present, NOT removing X (Close) button
- Clean up code

Bug:  788025 
Test: Try to play HD content that requires device id / verification.
Verify Harmoniousness of resultant dialog.

Change-Id: Ibcc300a97b6f2edd49d822171467162500d9e859
Reviewed-on: https://chromium-review.googlesource.com/946907
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561560}
[modify] https://crrev.com/1372e881962fd4356de525260f2d806dcfc8e0d7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1372e881962fd4356de525260f2d806dcfc8e0d7/chrome/browser/chromeos/attestation/platform_verification_dialog.cc
[modify] https://crrev.com/1372e881962fd4356de525260f2d806dcfc8e0d7/chrome/browser/chromeos/attestation/platform_verification_dialog.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e68ae441c86dd334ae2f90b83262e23d4b90013

commit 1e68ae441c86dd334ae2f90b83262e23d4b90013
Author: glevin <glevin@chromium.org>
Date: Fri Jun 01 17:13:26 2018

Revert string change on PlatformVerificationDialog

This restores the message string on this dialog to its previous version,
minus the "Learn more" link.

Bug:  788025 
Change-Id: Id9c93ed8d227a27ad050b9f7bbb921dfa69290db
Reviewed-on: https://chromium-review.googlesource.com/1081110
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563694}
[modify] https://crrev.com/1e68ae441c86dd334ae2f90b83262e23d4b90013/chrome/app/chromeos_strings.grdp

Labels: string-translation
Labels: Merge-Approved-68
The string revert is merge approved for 68.
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 7 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b0b1506e342620fd108c3d172af51e58bff44d2

commit 3b0b1506e342620fd108c3d172af51e58bff44d2
Author: glevin <glevin@chromium.org>
Date: Thu Jun 07 18:00:49 2018

Revert string change on PlatformVerificationDialog

This restores the message string on this dialog to its previous version,
minus the "Learn more" link.

Bug:  788025 
Change-Id: Id9c93ed8d227a27ad050b9f7bbb921dfa69290db
Reviewed-on: https://chromium-review.googlesource.com/1081110
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563694}(cherry picked from commit 1e68ae441c86dd334ae2f90b83262e23d4b90013)
Reviewed-on: https://chromium-review.googlesource.com/1091172
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#240}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/3b0b1506e342620fd108c3d172af51e58bff44d2/chrome/app/chromeos_strings.grdp

Status: Fixed (was: Started)

Sign in to add a comment