Harmony - update MultiprofilesIntroDialog |
||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/MultiprofileIntroDialog#%2FScreenshot%202017-11-13%20at%2015.27.32.png%3Fz=width&c=show for screenshot and required changes.
,
Nov 23 2017
,
Nov 23 2017
,
Apr 16 2018
,
Apr 17 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/1015786 generates the attached dialog (using --enable-features=SecondaryUiMd). Please take a look and let me know if it's sufficiently harmonious.
,
Apr 20 2018
- remove close-x
,
Apr 30 2018
LGTM
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1badbcec18529e79b5e781ffff9361f1dd00492a commit 1badbcec18529e79b5e781ffff9361f1dd00492a Author: glevin <glevin@chromium.org> Date: Wed May 02 17:29:52 2018 Harmonize MultiprofilesIntroDialog As per crbug.com/788022 Comments 1,6: - Consolidate 2 paragraphs into one - Fix padding between content area and buttons - Update "Don't show" checkbox text - Move "Don't show" checkbox from button to content area - Remove X (Close) button from upper right Bug: 788022 Test: Try to open second (multi) profile, view Multiprofile warning dialog, marvel at the unbearable Harmoniousness of it all. Change-Id: I1bb57e06b11c66e9b3cb3f3f4149ec8edcd35af5 Reviewed-on: https://chromium-review.googlesource.com/1015786 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555453} [modify] https://crrev.com/1badbcec18529e79b5e781ffff9361f1dd00492a/ash/ash_strings.grd [modify] https://crrev.com/1badbcec18529e79b5e781ffff9361f1dd00492a/ash/session/multiprofiles_intro_dialog.cc [modify] https://crrev.com/1badbcec18529e79b5e781ffff9361f1dd00492a/ash/session/multiprofiles_intro_dialog.h
,
May 14 2018
,
May 22 2018
Verified on ChromeOS 10704.0.0, 68.0.3437.0 dev-channel |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by x...@chromium.org
, Nov 23 2017