Harmony - update LogoutConfirmationDialog |
|||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/LogoutConfirmationDialog#%2FScreenshot%202017-11-13%20at%2015.23.53.png%3Fz=width&c=show for screenshot and required changes.
,
Nov 23 2017
,
Nov 23 2017
,
Nov 23 2017
,
Apr 20 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/1021992 generates the attached dialog (using --enable-features=SecondaryUiMd). Please take a look and let me know if it's sufficiently harmonious.
,
Apr 30 2018
Removing x-close expected. Otherwise, LGTM
,
May 14 2018
LGTM
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91df37b4bd999f78b8dd8bc1434f0f62f02f290a commit 91df37b4bd999f78b8dd8bc1434f0f62f02f290a Author: glevin <glevin@chromium.org> Date: Mon May 14 21:28:46 2018 Harmonize LogoutConfirmationDialog As per crbug.com/788021 Comments 1,6: - Width = 448px - Remove X (Close) button from upper right Bug: 788021 Test: Log out from a public session (not sure if this is sufficient), observe logout confirmation dialog, bask in Harmony. Change-Id: I965c3237f222a4acae809946e0cbb003f40f2b45 Reviewed-on: https://chromium-review.googlesource.com/1021992 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558469} [modify] https://crrev.com/91df37b4bd999f78b8dd8bc1434f0f62f02f290a/ash/system/session/logout_confirmation_dialog.cc [modify] https://crrev.com/91df37b4bd999f78b8dd8bc1434f0f62f02f290a/ash/system/session/logout_confirmation_dialog.h
,
May 14 2018
,
Jul 10
Verified on ChromeOS 10718.48.0, 68.0.3440.57 beta-channel kevin. Screenshot: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/788021/Screenshot%202018-07-11%20at%204.33.41%20AM.png?_ga=2.36131939.-2114348712.1530900974 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by x...@chromium.org
, Nov 22 2017