DevTools: dynamically updating <base> href doesn't update link tooltip in Elements panel |
|
Issue descriptionChrome Version: Chromium 64.0.3276.0 (Developer Build) (64-bit) Revision ab1b81aa16ef273213f3fdd381e0ca8749e7b816- OS: Linux What steps will reproduce the problem? (1) Go to a page with a <base> tag (see [1]) (2) Dynamically change the the href (e.g. $0.href = "http://foo.com) (3) Hover over a tag with src or href (e.g. <script src="...">) and notice the tool tip does *not* reflected the updated URL. However, if you query it directly $('script').src, you get the correct URL. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resources/elements-panel-rewrite-href-iframe.html?q=elements-panel-rewrite-href-iframe.html&sq=package:chromium This happens because we only call InspectorDOMAgent::InvalidateFrameOwnerElement on InspectorDOMAgent::DidCommitLoad which pushes updates with the correct link references. Layout test http/tests/devtools/elements/elements-panel-rewrite-href.js has a race condition and in theory should listen to an protocol event such as UpdatedLinkReferencesAfterBaseProcessed. Talking with @dgozman the use case for this protocol event might be very small since <base> usage is quite small. |
|
►
Sign in to add a comment |
|
Comment 1 by chenwilliam@chromium.org
, Dec 14 2017