Harmony - update IdleActionWarningDialog |
||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/IdleActionWarningDialogView#%2FScreenshot%202017-11-13%20at%2015.03.58.png%3Fz=width&c=show for screenshot and required changes.
,
Nov 23 2017
,
Nov 23 2017
,
Nov 23 2017
,
May 7 2018
Responding per request from email thread. From a UX writing perspective, the strings in this screenshot https://screenshot.googleplex.com/5x7bmUq9RpW.png are preferable to the "Are you still there/If you keep doing nothing" strings, with some minor tweaks. Title: You'll be signed out in 6 seconds Body: For security, sign out when your computer isn't being used
,
May 14 2018
srahim@ - Thanks for the reply. I can update the strings, but I still need to know which option from the screenshot is preferred. +hwi@ recommended Option A in the email thread. Do you concur?
,
May 18 2018
Option A SGTM.
,
May 18 2018
,
May 24 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/1070713 generates the attached dialog (using --enable-features=SecondaryUiMd). Please take a look and let me know if it's sufficiently harmonious.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56f9fa8ccb417eb385215ac23dcca4c8a6ecec3d commit 56f9fa8ccb417eb385215ac23dcca4c8a6ecec3d Author: glevin <glevin@chromium.org> Date: Thu May 24 18:32:36 2018 Harmonize IdleActionWarningDialog As per crbug.com/788019 Comments 1,5,7: - Width = 448px - Remove X (Close) button from upper right - Update title and body strings - Code cleanup - NOTE: Dialog has no buttons, is dismissed by any user action Bug: 788019 Test: Sit idle in Public Session (?), see if the Great Harmony will come and find you Change-Id: I160e93eb0fc9a788ef1c627b5459ca1e1d6c04de Reviewed-on: https://chromium-review.googlesource.com/1070713 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561562} [modify] https://crrev.com/56f9fa8ccb417eb385215ac23dcca4c8a6ecec3d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/56f9fa8ccb417eb385215ac23dcca4c8a6ecec3d/chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc [modify] https://crrev.com/56f9fa8ccb417eb385215ac23dcca4c8a6ecec3d/chrome/browser/chromeos/power/idle_action_warning_dialog_view.h
,
Jun 7 2018
,
Jul 10
Verified on ChromeOS 10718.48.0, 68.0.3440.57 beta-channel kevin. Attached screenshot: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/788019/IMG-9527.JPG?_ga=2.203904979.-2114348712.1530900974 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by x...@chromium.org
, Nov 22 2017