New issue
Advanced search Search tips

Issue 788018 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Nov 2017
Cc:
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[MD Extensions] Dev mode toolbar should not flicker

Project Member Reported by dbeam@chromium.org, Nov 22 2017 
Repro steps:

(0) Enable the Material Design version of chrome://extensions
(1) Navigate to chrome://extensions
(2) Enable developer mode
(3) Refresh the page

What is the expected result?
No flicker while loading.

What happens instead?
The toolbar (while loading) is like 30px too short.  Once the page realizes it's in developer mode it snaps to a larger height.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c271647190e96bdef672fc79d37a1235d9424f

commit 06c271647190e96bdef672fc79d37a1235d9424f
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Nov 28 06:11:02 2017

[MD Extensions] Fix toolbar flicker in dev mode

Track whether the page is being created (or refreshed) with dev mode on
by tracking the preference in C++ and changing the shim HTML/CSS via the
$i18n{...} mechanism.

Also set inDevMode in <extensions-manager> as soon as possible.

Bug:  788018 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I131cb04024cbfbaf4159a110ee1112346ea59a8c
Reviewed-on: https://chromium-review.googlesource.com/786441
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519589}
[modify] https://crrev.com/06c271647190e96bdef672fc79d37a1235d9424f/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/06c271647190e96bdef672fc79d37a1235d9424f/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/06c271647190e96bdef672fc79d37a1235d9424f/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/06c271647190e96bdef672fc79d37a1235d9424f/chrome/browser/ui/webui/extensions/extensions_ui.h

Comment 2 by dbeam@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment