New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788016 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Change Mac share command to "Email Link"

Project Member Reported by rpop@chromium.org, Nov 22 2017

Issue description

Per UI review feedback, please change "Email Page Location" to "Email Link"
 

Comment 1 by lgrey@chromium.org, Nov 27 2017

Should this apply to the current "Email Page Location" link too or leave that alone? (To put it another way: replace current string or add new string?)

Comment 2 by rpop@chromium.org, Nov 28 2017

Is there a different location that string appears, other than in the share command?

Comment 3 by lgrey@chromium.org, Nov 28 2017

It's the menu option that the Share Menu's replacing.

Comment 4 by rpop@chromium.org, Nov 28 2017

Will they ever appear simultaneously? Does this string appear on other platforms? I need a bit more. 

I think it should be updated but need to understand what I'm asking for.

Comment 5 by lgrey@chromium.org, Nov 28 2017

No they wouldn't appear simultaneously (just want to dot i's and cross t's here since the option will still be available for a bit and the string change might precede shipping share menu).

It's a Mac-only string.

Comment 6 by rpop@chromium.org, Nov 28 2017

Ok! In that case, I don't think we should change the old string. Let's introduce the new string with the new feature.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875cf13e107f44d264b24b579fba5abeb51d4c99

commit 875cf13e107f44d264b24b579fba5abeb51d4c99
Author: Leonard Grey <lgrey@chromium.org>
Date: Wed Nov 29 21:20:38 2017

[Mac] Change share email share extension menu string

Per discussion on bug, adding a new string instead of changing the old
one.

Bug:  788016 
Change-Id: I91a5f941fe6e91a04cdac08cd6c14aea6244e033
Reviewed-on: https://chromium-review.googlesource.com/797442
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520247}
[modify] https://crrev.com/875cf13e107f44d264b24b579fba5abeb51d4c99/chrome/app/generated_resources.grd
[modify] https://crrev.com/875cf13e107f44d264b24b579fba5abeb51d4c99/chrome/browser/ui/cocoa/share_menu_controller.mm

Comment 8 by lgrey@chromium.org, Nov 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment