New issue
Advanced search Search tips

Issue 788014 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 783540



Sign in to add a comment

Harmony - Update CancelCastingDialog

Project Member Reported by x...@chromium.org, Nov 22 2017

Issue description

Comment 1 by x...@chromium.org, Nov 23 2017

Blocking: 630357

Comment 2 by tapted@chromium.org, Nov 23 2017

Blocking: -630357

Comment 3 by tapted@chromium.org, Nov 23 2017

Blocking: 783540

Comment 4 by glevin@chromium.org, May 17 2018

Labels: -M-65 M-68
Owner: glevin@chromium.org
Status: Started (was: Untriaged)
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/1065021 generates the attached dialog (using --enable-features=SecondaryUiMd).  Please take a look and let me know if it's sufficiently harmonious.

Comment 5 by glevin@chromium.org, May 17 2018

... and actually attaching a screenshot...
hd_cancelcast_v1.png
18.2 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3028a826d1da5b9822cdfff31f3d3d7d613e981a

commit 3028a826d1da5b9822cdfff31f3d3d7d613e981a
Author: glevin <glevin@chromium.org>
Date: Thu Jun 07 18:06:55 2018

Harmonize CancelCastingDialog

As per  crbug.com/788014  Comment 1 (and previous dlgs):
- Change button text "OK" -> "Continue"
- Remove X (Close) button from upper right

Bug:  788014 
Test: Cast to a screen while multi-logged in. Try switching profiles.
Try to spot the Harmony.

Change-Id: Icdb122f100d6f0b00129da7534150b7314a17686
Reviewed-on: https://chromium-review.googlesource.com/1065021
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565345}
[modify] https://crrev.com/3028a826d1da5b9822cdfff31f3d3d7d613e981a/ash/ash_strings.grd
[modify] https://crrev.com/3028a826d1da5b9822cdfff31f3d3d7d613e981a/ash/system/screen_security/screen_switch_check_controller.cc

Labels: Merge-Request-68
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: There is .grd file changes and we are only 45 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by glevin@chromium.org, Jun 10 2018

Labels: -Hotlist-Merge-Review -M-68 -Merge-Review-68 M-69
Status: Fixed (was: Started)
*facepalm* I somehow missed that this one had a string change.  The CL is minor, and omrilio@ agrees with me that this can just wait till M-69.  Merge request rescinded.

Sign in to add a comment