Harmony - update ArcAppDialogView |
||||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome See https://folio.googleplex.com/_/preview/1sFARH7Ox4zR2zb8Y6PsgWvl0Nrbxouj6/ArcAppDialogView#%2FScreenshot%202017-11-13%20at%2011.46.43.png%3Fz=width&c=show for current screenshot and required change. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 23 2017
,
Nov 23 2017
,
May 18 2018
The first patchset at https://chromium-review.googlesource.com/c/chromium/src/+/1066450 generates the attached dialogs (using --enable-features=SecondaryUiMd). Please take a look and let me know if they're sufficiently harmonious. Note: The screenshot from Comment #1 only shows one of the three dialogs generated by this code. The other two deal with USB access permissions for ARC++ apps. Their widths are currently 512, 448, and 320px. bettes@ - Let me know if you'd like me to make them all 448px. Also, dialogs 1 & 3 (uninstall and usbaccess) have the text hard-coded to be on two lines, with different strings for each line. In the past you've had me remove line breaks; let me know if I should do the same here, or if these are okay as they are.
,
May 21 2018
Thanks glevin@. Yes, let's make all three 448px. Before I sign off on the line breaking issue, is Polytron a USB accessory?
,
May 23 2018
,
May 23 2018
> Thanks glevin@. Yes, let's make all three 448px. Will do, thanks. > Before I sign off on the line breaking issue, is Polytron a USB accessory? Yes, it's a semi-fictional USB accessory I mocked up for the screenshots.
,
May 31 2018
Here are the 3 dialogs all at width = 448px. bettes@, let me know if the line breaks in dialogs 1 & 3 are okay as is.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd76ea1423c1350eb1745855779f6efc4169fdeb commit bd76ea1423c1350eb1745855779f6efc4169fdeb Author: glevin <glevin@chromium.org> Date: Thu Jun 07 18:02:21 2018 Harmonize ArcAppDialogView Note that there are 3 app dialogs here generated by the same code: one for uninstalling, one for USB list permission, and one for USB access permission. As per crbug.com/788010 Comment 1 (and previous dlgs): - Allow text to run to right edge of dialog (minus margin) - Remove X (Close) button from upper right - Width = 448px Bug: 788010 Test: Try to uninstall an ARC++ app, or use one to access USB devices. OMG Harmony! Change-Id: I6ffe099ba9f4fe3fae7cd3b6f203873000dd62e8 Reviewed-on: https://chromium-review.googlesource.com/1066450 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565339} [modify] https://crrev.com/bd76ea1423c1350eb1745855779f6efc4169fdeb/chrome/browser/ui/views/arc_app_dialog_view.cc
,
Jun 7 2018
,
Jun 8 2018
The bug is marked as P3 or Feature. It should not be merged as M68 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 11 2018
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/916fb08d9b54f8e0c360606ba936e428d2d7c2b4 commit 916fb08d9b54f8e0c360606ba936e428d2d7c2b4 Author: glevin <glevin@chromium.org> Date: Mon Jun 11 19:37:17 2018 Harmonize ArcAppDialogView Note that there are 3 app dialogs here generated by the same code: one for uninstalling, one for USB list permission, and one for USB access permission. As per crbug.com/788010 Comment 1 (and previous dlgs): - Allow text to run to right edge of dialog (minus margin) - Remove X (Close) button from upper right - Width = 448px Bug: 788010 Test: Try to uninstall an ARC++ app, or use one to access USB devices. OMG Harmony! Change-Id: I6ffe099ba9f4fe3fae7cd3b6f203873000dd62e8 Reviewed-on: https://chromium-review.googlesource.com/1066450 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565339}(cherry picked from commit bd76ea1423c1350eb1745855779f6efc4169fdeb) Reviewed-on: https://chromium-review.googlesource.com/1095957 Reviewed-by: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#283} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/916fb08d9b54f8e0c360606ba936e428d2d7c2b4/chrome/browser/ui/views/arc_app_dialog_view.cc
,
Jun 11 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by x...@chromium.org
, Nov 23 2017