GN incorrectly refers to lib_prefix and lib_dir_prefix in some places |
||
Issue descriptionI believe it should be lib_switch and lib_dir_switch globally, but there's a few places that incorrectly call it lib_[dir_]prefix which confused me.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/mini_chromium/+/a70db15bf9985b124c1805c401d7c384a7195845 commit a70db15bf9985b124c1805c401d7c384a7195845 Author: Scott Graham <scottmg@chromium.org> Date: Tue Nov 28 00:10:55 2017 Improvements to GN build config - Basic implementation of solink_module tool - Further uniquize the .o names, as in Crashpad, some .cc files are built multiple times with different #defines (e.g. crashpad_info_size_test_module.cc near https://chromium.googlesource.com/crashpad/crashpad/+/master/snapshot/BUILD.gn#286) - Set lib_switch and lib_dir_switch - Remove probably-not-working is_clang GN variable. - Refer to fuchsia SDK/clang that are now downloaded in runhooks. Bug: crashpad:79, crashpad:196, chromium:788007 Change-Id: I795b7a5ad211076f38424798b37350dec8a1eb14 Reviewed-on: https://chromium-review.googlesource.com/786676 Reviewed-by: Mark Mentovai <mark@chromium.org> [modify] https://crrev.com/a70db15bf9985b124c1805c401d7c384a7195845/build/BUILD.gn [modify] https://crrev.com/a70db15bf9985b124c1805c401d7c384a7195845/build/BUILDCONFIG.gn
,
Nov 28 2017
Online .md does are updated already by the CL, `gn help` won't be updated until gn rolls, but I'm not going to do that just for this small fix. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 23 2017