New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788004 link

Starred by 2 users
Status: Fixed
Owner:
s...@chromium.org
Closed: Dec 2017
Cc:
asvitk...@chromium.org
mastiz@chromium.org
skare@chromium.org
isherman@chromium.org
█ tschumann@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename variations::CHROME_SYNC_SERVICE to CHROME_SYNC_EVENT_LOGGER

Project Member Reported by s...@chromium.org, Nov 22 2017 
See https://chromium-review.googlesource.com/c/chromium/src/+/764408/12/components/sync/user_events/trial_recorder.cc#87 for original request. Now that we're using this IDCollectionKey to specifically send data through event logger, it makes sense to update the name to keep things as clear as possible.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a846ad7dac3d39852c922f37c2955d1cac582193

commit a846ad7dac3d39852c922f37c2955d1cac582193
Author: Sky Malice <skym@chromium.org>
Date: Tue Dec 05 00:44:42 2017

Rename CHROME_SYNC_SERVICE to CHROME_SYNC_EVENT_LOGGER

Bug:  788004 
Change-Id: I455ac63969e5ab52ef063fbd1b9ba14be833f211
Reviewed-on: https://chromium-review.googlesource.com/806653
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521555}
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/sync/user_events/trial_recorder.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/sync/user_events/trial_recorder_unittest.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/sync/user_events/user_event_service_impl_unittest.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/variations/variations_associated_data.h
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/variations/variations_associated_data_unittest.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/a846ad7dac3d39852c922f37c2955d1cac582193/components/variations/variations_seed_processor.cc

Comment 2 by s...@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment