New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787979 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Windows should use the same compiler optimization flags as other platforms

Project Member Reported by lfg@chromium.org, Nov 22 2017

Issue description

Now that Windows is using clang, does it still make sense to build Windows with size optimization rather than speed[1]? If it does, then should Linux/Mac also use optimize for size?

[1] https://chromium.googlesource.com/chromium/src/+/6c9aa01842b041e38243a51e09d446274c7b5297/build/config/compiler/BUILD.gn#1688

 

Comment 1 by thakis@chromium.org, Nov 27 2017

Cc: p...@chromium.org h...@chromium.org
Labels: OS-Linux OS-Mac
Both Android and Windows optimize for size, and that's where almost all users are. Imo we should try and use consistent optimization flags everywhere. pcc tried making mac/linux use the android flags before, but it regressed perf a bit. pcc might have a link to the actual numbers.

If someone's motivated, going through the regressions, seeing which of them we could live with, and which we should work on (by rewriting code, enabling o2 for small targets, etc -- which would speed up things on android) and then trying again would be a great project.

(Windows and Android probably use slightly different gn flags too and should eventually match, but they at least agree on the basic flag setup iirc that we should generally prefer size except for hot code.)

Sign in to add a comment