RSA key generation Web Platform Tests are very slow and time out on try bots |
||
Issue descriptionThe following Web Platform Tests (in LayoutTests/external/wpt) are very slow: WebCryptoAPI/generateKey/successes_RSA-OAEP.https.worker.html WebCryptoAPI/generateKey/successes_RSA-PSS.https.worker.html WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.worker.html WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html WebCryptoAPI/generateKey/test_successes_RSA-PSS.https.html WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.https.html The files have comments saying "Warning! RSA key generation is intrinsically very slow, so the related tests can take up to several minutes to complete, depending on browser!" which is exactly true. Even when marked as [ Slow ] and given 30s timeout, these tests still time out sometimes (especially on Mac). Note: the failure tests do not (and should not) time out. They are testing illegal parameters, which should be rejected immediately.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc247f7b0fb5439c9494ef1a21312731a76e5a7e commit bc247f7b0fb5439c9494ef1a21312731a76e5a7e Author: Robert Ma <robertma@chromium.org> Date: Wed Nov 22 23:14:57 2017 Mark all RSA key generation tests as flaky timeout And use a new dedicated issue for them. TBR=eroman@chromium.org Bug: 757698 , 787971 Change-Id: If51835eb88cf12ba2a16fe655aa2b54d2df97f2e Reviewed-on: https://chromium-review.googlesource.com/786261 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#518791} [modify] https://crrev.com/bc247f7b0fb5439c9494ef1a21312731a76e5a7e/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 23 2017
Issue 788193 has been merged into this issue.
,
Jan 5 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29306ef9451df45917273a80063b91d697e70188 commit 29306ef9451df45917273a80063b91d697e70188 Author: Robert Ma <robertma@chromium.org> Date: Thu Jan 11 23:43:08 2018 Adjust TestExpectations for an incoming upstream rename Upstream renamed a bunch of WebCryptoAPI tests to run in secure context. Due to https://crbug.com/801357, these renames cannot be automatically picked up by wpt-import. We are expecting: 1. Most tests should run fine now that they are in secure context, but the old expectations are kept for now to prevent CQ/waterfall failing. 2. wrapKey_unwrapKey.https.worker.html will be slow, so add it to SlowTests. Also change a bug link for another WebCryptoAPI test as 799547 has been duped into 787971. TBR=qyearsley Bug: 787971 , 799547 , 801357 No-Try: True Change-Id: Id722cc4601d4bf5f2c4fbb564219eb3b89034f89 Reviewed-on: https://chromium-review.googlesource.com/862264 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#528817} [modify] https://crrev.com/29306ef9451df45917273a80063b91d697e70188/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/29306ef9451df45917273a80063b91d697e70188/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 3 2018
What bit length and how many of RSA keys are these tests trying to generate?
,
Apr 3 2018
From glancing at the code, I expect it is doing 60 generateKey() for 2048-bit RSA.
,
May 14 2018
Upstream PR: https://github.com/w3c/web-platform-tests/pull/10984
,
May 15 2018
Upstream PR is now landed. When the upstream change is synced, you may want to check if these tests are stable and update TestExpectations.
,
May 15 2018
Thanks for the change @zcorpan!
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/911054f7d0f8472be6059cc730e1bf5f593e7010 commit 911054f7d0f8472be6059cc730e1bf5f593e7010 Author: Robert Ma <robertma@chromium.org> Date: Fri May 18 11:30:45 2018 Remove some test expectations for WebCryptoAPI WPT These tests are fixed (split) upstream so they no longer timeout. https://github.com/w3c/web-platform-tests/pull/11028 Bug: 787971 Change-Id: I4441a36cc254a1f0069d7d157c8c54d6a33781ad Reviewed-on: https://chromium-review.googlesource.com/1065144 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#559863} [modify] https://crrev.com/911054f7d0f8472be6059cc730e1bf5f593e7010/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 21 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9fa851ff259ed374cdb0af3cf19fbc68562c175 commit e9fa851ff259ed374cdb0af3cf19fbc68562c175 Author: Robert Ma <robertma@chromium.org> Date: Thu Jun 21 20:15:45 2018 Remove two stale expectations The two WebCryptoAPI tests have been fixed (and renamed) in upstream (https://github.com/web-platform-tests/wpt/issues/10794) and we can now safely remove these two expectations. TBR=foolip No-Try: True Bug: 787971 Change-Id: I76a0c288e37ef92c30d936d76d652e65ab9d204b Reviewed-on: https://chromium-review.googlesource.com/1110738 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#569368} [modify] https://crrev.com/e9fa851ff259ed374cdb0af3cf19fbc68562c175/third_party/WebKit/LayoutTests/TestExpectations |
||
►
Sign in to add a comment |
||
Comment 1 by rsleevi@chromium.org
, Nov 22 2017