New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787964 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD extensions] [errors console] "ERRORS" sub-page should have a "Clear all" button

Reported by woxxom@gmail.com, Nov 22 2017

Issue description

1. go to chrome://extensions
2. enable "developer mode" on the top-right
3. install the attached extension 
4. click the red "ERRORS" label

Expected: a button to remove all messages
Observed: no such button

This is a regression in the new MD-extensions (issue 529395). An extension may print lots of useful (or not) information during local development and we absolutely need the pre-MD "Clear all errors" button back.

============================================================
Chrome 64.0.3275.0 (Official Build) canary (64-bit) Win7x64

Related: the label is also a bit misleading ( issue 740404 ) and the animation of the code box that shows the error source in this panel may be extremely slow when the script is huge. rdevlin@, should I open a new issue with a testcase or is it useless? IIRC all requests to disable UI animations were eventually declined for the last year or so :-)
 
md-ext-spam-console.zip
594 bytes Download
error-panel.png
14.9 KB View Download
Cc: sc00335...@techmahindra.com
Labels: -Pri-3 M-64 Proj-MaterialDesign-WebUI Needs-Triage-M64 Triaged-ET OS-Linux OS-Mac OS-Windows Pri-2
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on 64.0.3275.0 using Mac 10.12.6, Windows 10 and Ubuntu 14.04 with attached sample extension.

This issue is seen from the introduction of errors options in M64. Hence considering this issue as Non-Regression for MD-Extensions and marking as Untriaged.
Summary: [MD extensions] [errors console] "ERRORS" sub-page should have a "Clear all" button (was: MD-extensions "ERRORS" sub-page should have a "Clear all" button)
Labels: Hotlist-MD-Extensions-ErrorConsole
Grouping all error-console related bugs into a hotlist, so that we can better keep track of them.
FYI, the scroll-animation being slow for large files is being worked on and tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=781335
Owner: scottchen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4adc0f5c0c3eef4265d039cfe6afc28d7037cc63

commit 4adc0f5c0c3eef4265d039cfe6afc28d7037cc63
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Dec 13 20:58:09 2017

MD Extensions: add button to clear all error from error console.

Bug:  787964 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54837b7ffb8166c74ce9d06946d3c0b9e7211bee
Reviewed-on: https://chromium-review.googlesource.com/818330
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523872}
[modify] https://crrev.com/4adc0f5c0c3eef4265d039cfe6afc28d7037cc63/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/4adc0f5c0c3eef4265d039cfe6afc28d7037cc63/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/4adc0f5c0c3eef4265d039cfe6afc28d7037cc63/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/4adc0f5c0c3eef4265d039cfe6afc28d7037cc63/chrome/browser/ui/webui/extensions/extensions_ui.cc

Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 7,10 ,Mac 10.12.6 & Ubuntu 14.04 using chrome latest canary#65.0.3294.0 as per C#0.

Able to view 'Error' button for the loaded extension & observed 'Clear All' button to delete the errors on Mac & Linux OS Where as 'Error' button is displayed  for the loaded extension on Windows 7 & 10 OS.Hence unable to verify the fix on Windows OS.

Please find the attached screencast of both Mac & windows OS for reference.

scottchen@,Please check and fix the same on Windows OS.

Thanks..!


787964.mp4
5.1 MB View Download
787964-Win 1o-Fail.mp4
3.2 MB View Download
Status: Fixed (was: Started)
will file another bug for not being able to see the 'error' button on some platforms. Marking the "clear all" feature as done.

Sign in to add a comment