Possible memory leaks associated with ShareKit? |
||
Issue descriptionChrome Version: 64.0.3275.0 (approximately) OS: macOS 10.12.6 What steps will reproduce the problem? (1) Create an Instruments document with a Leaks instrument and attach to a running copy of Chromium. (2) Navigate a few times, open and close windows, etc. What is the expected result? No leaks detected. What happens instead? A bunch of small leaks appear which mention ShareKit. Not sure yet whether this is a buggy SDK or leaks in Chrome, but could be worth checking out. I attached a screenshot and highlighted a few of the suspicious lines.
,
Nov 27 2017
Filed as Radar 35699592
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2d55a253ceb67d8c2218e35a449d7b4abc003df commit f2d55a253ceb67d8c2218e35a449d7b4abc003df Author: Leonard Grey <lgrey@chromium.org> Date: Tue Nov 28 14:57:17 2017 [Mac] Avoid calling |sharingServiceNamed:| in share menu 1) For general efficiency and to avoid the leak mentioned in the linked bug, compare share services via the previously exposed |name| method. 2) Now that |name| is available, restrict the temporary activity spawned while sharing to the Reminders service, since that's the only one that needs it. Bug: 787955 Change-Id: I6d2a38f8b1cba3b3a3a4e1edb9c06408ae9f1c41 Reviewed-on: https://chromium-review.googlesource.com/791333 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#519685} [modify] https://crrev.com/f2d55a253ceb67d8c2218e35a449d7b4abc003df/chrome/browser/ui/cocoa/share_menu_controller.mm
,
Jan 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by lgrey@chromium.org
, Nov 27 2017