New issue
Advanced search Search tips

Issue 787946 link

Starred by 1 user
Status: WontFix
Owner:
bokan@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 791734



Sign in to add a comment

ViewportHistogramsTests fail on first run, pass on retry

Project Member Reported by pdr@chromium.org, Nov 22 2017 
./out/Debug/webkit_unit_tests --gtest_filter=*Viewport*

../../base/test/histogram_tester.cc:40: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Viewport.MetaTagType" does not exist.
[  FAILED  ] ViewportHistogramsTest.TypeNone (10 ms)

These tests don't fail on their own so it's likely a test in this area is leaving state dirty between tests.

This is a regression from https://chromium.googlesource.com/chromium/src/+/d7b7b69363c89ab6f5aa9f276337a3b1b9707c75

Comment 1 by w...@chromium.org, Dec 4 2017

Components: Tests>Flaky
Labels: -Pri-2 M-65 Pri-1
Failures look like:
2657/7306] ViewportHistogramsTest.NoOpOnWhenViewportDisabled (23 ms)
[ RUN      ] ViewportHistogramsTest.TypeNone
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Viewport.MetaTagType" does not exist.
[  FAILED  ] ViewportHistogramsTest.TypeNone (21 ms)
[2658/7306] ViewportHistogramsTest.TypeNone (21 ms)
[ RUN      ] ViewportHistogramsTest.TypeDeviceWidth
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Viewport.MetaTagType" does not exist.
[  FAILED  ] ViewportHistogramsTest.TypeDeviceWidth (15 ms)
[2659/7306] ViewportHistogramsTest.TypeDeviceWidth (15 ms)
[ RUN      ] ViewportHistogramsTest.TypeConstant
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Viewport.MetaTagType" does not exist.
[  FAILED  ] ViewportHistogramsTest.TypeConstant (15 ms)

Comment 2 by w...@chromium.org, Dec 4 2017

Blocking: 791734

Comment 3 by isherman@chromium.org, Feb 27 2018

Components: -Internals>Metrics>UMA

Comment 4 by bokan@chromium.org, Mar 21 2018

Status: WontFix (was: Assigned)
This seems to no longer happen - I've tried:

./out/ChromeDebug/webkit_unit_tests --test-launcher-retry-limit=0 --gtest_filter="*Viewport*"

As well as the full suite:

./out/ChromeDebug/webkit_unit_tests --test-launcher-retry-limit=0

And don't see this anymore so I'll close this bug. Let me know if I'm missing something in reproducing.
►

Sign in to add a comment