SitePerProcessBrowserTest crash on WaitForChildFrameSurfaceReady |
|||
Issue descriptionSeveral tests are using the test api WaitForChildFrameSurfaceReady. This currently does not work in --enable-viz due to issue 763452 Failing tests: SitePerProcessBrowserTest.CancelWheelScrollBubblingOnWheelTargetDeletion SitePerProcessBrowserTest.CreateContextMenuTest SitePerProcessBrowserTest.CrossProcessMouseCapture SitePerProcessBrowserTest.CrossProcessMouseEnterAndLeaveTest SitePerProcessBrowserTest.CursorUpdateReceivedCrossSiteIframe SitePerProcessBrowserTest.GestureFlingStartEventsBubble SitePerProcessBrowserTest.InputEventRouterGesturePreventDefaultTargetMapTest SitePerProcessBrowserTest.InputEventRouterGestureTargetMapTest SitePerProcessBrowserTest.InputEventRouterTouchpadGestureTargetTest SitePerProcessBrowserTest.NavigateCrashedSubframeToSameSite SitePerProcessBrowserTest.NestedSurfaceHitTestTest SitePerProcessBrowserTest.PopupMenuTest SitePerProcessBrowserTest.RootConsumesScrollDuringOverscrollGesture SitePerProcessBrowserTest.ScrollBubblingFromNestedOOPIFTest SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest SitePerProcessBrowserTest.ScrollEventToOOPIF SitePerProcessBrowserTest.SubframeTouchEventRouting SitePerProcessBrowserTest.SurfaceHitTestPointerEventsNone SitePerProcessBrowserTest.SurfaceHitTestTest SitePerProcessBrowserTest.TwoSubframesCreatePopupMenuWidgetsSimultaneously SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54c0b8052525055df08be869503f645168d203ba commit 54c0b8052525055df08be869503f645168d203ba Author: jonross <jonross@chromium.org> Date: Wed May 30 15:36:40 2018 Update How WebViewTest.ReloadAfterCrash waits for frames WebViewTest.ReloadAfterCrash wants to wait for frames to have been produced, but is not interested in hit test data. It has been using WaitForChildFrameSurfaceReady which does not work with VizDisplayCompositor. This updates it to using RenderFrameSubmissionObserver which works with both classic compositing and Viz. TEST=WebViewTest.ReloadAfterCrash Bug: 787945 Change-Id: I1358b0780964cff0298f6e8851dd629bbd14dc44 Reviewed-on: https://chromium-review.googlesource.com/1076778 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#562837} [modify] https://crrev.com/54c0b8052525055df08be869503f645168d203ba/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/54c0b8052525055df08be869503f645168d203ba/testing/buildbot/filters/viz.browser_tests.filter
,
May 30 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a8c7da771970b12e2453be33cf0df6a83d369d7 commit 0a8c7da771970b12e2453be33cf0df6a83d369d7 Author: Jonathan Ross <jonross@chromium.org> Date: Wed Jun 13 16:44:50 2018 Update how SitePerProcessMacBrowserTest waits for hit test data Currently SitePerProcessMacBrowserTest.InputEventRouterTouchpadGestureTargetTest does not work on Viz. This change updates it to use the new hit test data api. TEST: SitePerProcessMacBrowserTest.InputEventRouterTouchpadGestureTargetTest Bug: 787945 Change-Id: I5aec8787ca1cf73e04aa8801b8d6af53d471c601 Reviewed-on: https://chromium-review.googlesource.com/1099044 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#566865} [modify] https://crrev.com/0a8c7da771970b12e2453be33cf0df6a83d369d7/content/browser/site_per_process_mac_browsertest.mm [modify] https://crrev.com/0a8c7da771970b12e2453be33cf0df6a83d369d7/testing/buildbot/filters/viz.content_browsertests.filter
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7de3aa5875c6e5e59c6d761be41ad9e05b60645b commit 7de3aa5875c6e5e59c6d761be41ad9e05b60645b Author: jonross <jonross@chromium.org> Date: Mon Jun 18 17:33:43 2018 Update TouchAccessibilityBrowserTest hit test waiting Currently TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe is calling WaitForChildFrameSurfaceReady. However it is not actually waiting, as the frame it is providing is not a RenderWidgetHostViewChildFrame. This change updates the call to the new hit testing api HitTestRegionObserver. This will allow the test to properly wait on hit testing data while run under Viz. While maintaining the current early exit for non-Viz. TEST=TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe Bug: 787945 Change-Id: Ica7fa92e7dcb5ea3d7a5b9702f9c5d077d929c07 Reviewed-on: https://chromium-review.googlesource.com/1102570 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568054} [modify] https://crrev.com/7de3aa5875c6e5e59c6d761be41ad9e05b60645b/content/browser/accessibility/touch_accessibility_aura_browsertest.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dff175993a76918ff962e8165b48202ef7b6d361 commit dff175993a76918ff962e8165b48202ef7b6d361 Author: jonross <jonross@chromium.org> Date: Mon Jun 18 17:38:08 2018 Update Android SitePerProcessHitTest to new Hit Test Api I missed a few callsites to WaitForChildFrameSurfaceReady which were in Android tests. This change updates them to use the new HitTestRegionObserver TEST=TouchSelectionControllerClientAndroidSiteIsolationTest.BasicSelectionIsolatedIframe SitePerProcessHitTestBrowserTest.CrossProcessTooltipTestAndroid Bug: 787945 Change-Id: I0abfa8e4c036552ac416909b15398a53a71ee064 Reviewed-on: https://chromium-review.googlesource.com/1102829 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568059} [modify] https://crrev.com/dff175993a76918ff962e8165b48202ef7b6d361/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/dff175993a76918ff962e8165b48202ef7b6d361/content/browser/site_per_process_hit_test_browsertest.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03870c0449c4bb48103a147a84eb42e99ef5f482 commit 03870c0449c4bb48103a147a84eb42e99ef5f482 Author: jonross <jonross@chromium.org> Date: Wed Jun 20 18:12:29 2018 Remove legacy WaitForChildFrameSurfaceReady from browser_test_utils HitTestRegionObserver was created to replace WaitForChildFrameSurfaceReady. However until the new hit testing api is on by default, it is needed for testing the legacy path. By now all callsites to it have been changed to HitTestRegionObserver. So this change removes it from browser_test_utils, and hides it inside of HitTestRegionObserver to prevent new callsites from being added. I'll delete it once and for all once the new hit testing api is on by default. TBR=piman@chromium.org TEST=content_browsertests, browser_tests, interactive_ui_tests Bug: 787945 Change-Id: I9db70ef06bd327f95db39ab5174df49db538eea4 Reviewed-on: https://chromium-review.googlesource.com/1106048 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568928} [modify] https://crrev.com/03870c0449c4bb48103a147a84eb42e99ef5f482/content/public/test/browser_test_utils.cc [modify] https://crrev.com/03870c0449c4bb48103a147a84eb42e99ef5f482/content/public/test/browser_test_utils.h [modify] https://crrev.com/03870c0449c4bb48103a147a84eb42e99ef5f482/content/public/test/hit_test_region_observer.cc [modify] https://crrev.com/03870c0449c4bb48103a147a84eb42e99ef5f482/content/public/test/hit_test_region_observer.h
,
Jun 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jonr...@chromium.org
, May 23 2018