New issue
Advanced search Search tips

Issue 787927 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR



Sign in to add a comment

UI unit tests shouldn't need to advance time to verify future visibility

Project Member Reported by cjgrant@chromium.org, Nov 22 2017

Issue description

Many VR UI scene tests manipulate the model and verify resulting element visibilty.  For animated elements, this requires advancing time to let animations either start or complete.

The animation aspect is relatively separate from the notion of whether an element will become visible/invisible in the future.

To improve ease of testing, we should implement a GetTargetVisibility variant that walks the tree and determines the true future visibility of an element.  Unit test IsVisible helpers would switch to use this, and time-advancing would no longer be necessary in most tests.
 
Status: Fixed (was: Assigned)
This was done in this CL:

https://chromium-review.googlesource.com/c/chromium/src/+/788282

No verification needed.
Labels: M-64 Test-Complete
Components: Internals>XR

Sign in to add a comment