New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787926 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Remove the disable button from media remoting interstitial

Project Member Reported by x...@chromium.org, Nov 22 2017

Issue description

Since the disable feature is moving to the Media Router dialog ( crbug.com/774245 ), the current disable button in the video content area for Media Remoting need to be removed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8883564afcf037c6970d501005c293697706e8d5

commit 8883564afcf037c6970d501005c293697706e8d5
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Mon Nov 27 17:38:07 2017

Remove the disable button from the Media Remoting interstial.

This feature is moving to the Media Router dialog in a coming patch.
This CL removed the current disable button from the Media Remoting
interstial.

Bug:  787926 
Change-Id: I89dc4635e334ed6bca6f8b6e8d171b9df32413cb
Reviewed-on: https://chromium-review.googlesource.com/786311
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519328}
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/content/app/strings/content_strings.grd
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/content/child/blink_platform_impl.cc
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/core/html/media/HTMLVideoElement.cpp
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/core/html/media/HTMLVideoElement.h
[delete] https://crrev.com/c089973135e23390585fdf6a6f949ae3a854a563/third_party/WebKit/Source/core/html/media/MediaRemotingElements.cpp
[delete] https://crrev.com/c089973135e23390585fdf6a6f949ae3a854a563/third_party/WebKit/Source/core/html/media/MediaRemotingElements.h
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.cpp
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.h
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControlsAndroid.css
[modify] https://crrev.com/8883564afcf037c6970d501005c293697706e8d5/third_party/WebKit/public/platform/WebLocalizedString.h

Comment 2 by x...@chromium.org, Nov 27 2017

Status: Fixed (was: Started)

Sign in to add a comment