New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787918 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Remove most trybot configurations from the builder-trybot mapping

Project Member Reported by robert...@chromium.org, Nov 22 2017

Issue description

As we migrate to luci, all tryjobs will be done by the same "builder", namely 'findit_variable' on 'luci.chromium.try'

Thus, it is unnecessary to specify a trybot and mastername for each.

Instead, having `'use_swarmbucket': True` as one of the entries for the builder should be enough for findit to use such default values.
 
Blocking: -786520
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b7f9ca2bac436555e9eb29ea8997f5c9b283fe17

commit b7f9ca2bac436555e9eb29ea8997f5c9b283fe17
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Jul 17 20:52:19 2018

New Findit recipe to export bot_db to Google Storage.

Exporting this db is needed to make Findit aware of builder types
(builders vs testers) from the canonical truth and replace a manually
updated mapping and name-based assumptions.

R=chanli,stgao,iannucci,jbudorick

Bug: 787918
Change-Id: I3e4fbe1215fe882488e49977d468032731819701
Reviewed-on: https://chromium-review.googlesource.com/1123409
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/b7f9ca2bac436555e9eb29ea8997f5c9b283fe17/scripts/slave/README.recipes.md
[add] https://crrev.com/b7f9ca2bac436555e9eb29ea8997f5c9b283fe17/scripts/slave/recipes/findit/chromium/export_bot_db.py
[add] https://crrev.com/b7f9ca2bac436555e9eb29ea8997f5c9b283fe17/scripts/slave/recipes/findit/chromium/export_bot_db.expected/with_mock_bdb.json

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fedfcdf198fe0c644c377503cc3d103eef370ba2

commit fedfcdf198fe0c644c377503cc3d103eef370ba2
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Jul 17 22:39:22 2018

New builder to run findit/chromium/export_bot_db periodically.

This builder is meant to be used with a cron job on luci scheduler to
update the bot_db as a json file in google storage readable by Findit.
(Instead of having Findit attempt to parse the python files where these
configs are defined, under the chromium_tests recipe module).

R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv

Bug: 787918
Change-Id: I668eaef3511ff82795ff80a2650ecadd741cd861
Reviewed-on: https://chromium-review.googlesource.com/1141092
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575816}
[modify] https://crrev.com/fedfcdf198fe0c644c377503cc3d103eef370ba2/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f53fc9369a1e0b8a48aa54d84c9e09b54540d9

commit 95f53fc9369a1e0b8a48aa54d84c9e09b54540d9
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Jul 18 00:47:49 2018

Create cron schedule for bot-db exporter recipe.

R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv

Bug: 787918
Change-Id: I0766fa1c9d575b9960d336152aa62c56a7a2b945
Reviewed-on: https://chromium-review.googlesource.com/1141117
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575878}
[modify] https://crrev.com/95f53fc9369a1e0b8a48aa54d84c9e09b54540d9/infra/config/global/luci-scheduler.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/300793b34dba11ad79d8df08e534ee8a74bd1adc

commit 300793b34dba11ad79d8df08e534ee8a74bd1adc
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon Jul 23 20:48:10 2018

Add service to read exported bot_db.

Also, make build aheads use such service. Note that the platform has
been redefined to refer to the ['testing']['platform'] property of
bot_db for a given builder. So linux, android and chromeos now use
'linux' rather than 'unix'/'android', and this makes sense as it more
closely matches the swarming dimensions of the bots that would run the
builds.

R=chanli,stgao,liaoyuke,lijeffrey

Bug: 787918
Change-Id: I1f65d91ba5a2626f42d68be5bbbfb7b308b5f808
Reviewed-on: https://chromium-review.googlesource.com/1145779
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[add] https://crrev.com/300793b34dba11ad79d8df08e534ee8a74bd1adc/appengine/findit/services/bot_db.py
[modify] https://crrev.com/300793b34dba11ad79d8df08e534ee8a74bd1adc/appengine/findit/services/build_ahead.py
[modify] https://crrev.com/300793b34dba11ad79d8df08e534ee8a74bd1adc/appengine/findit/services/test/build_ahead_test.py
[add] https://crrev.com/300793b34dba11ad79d8df08e534ee8a74bd1adc/appengine/findit/services/test/bot_db_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8437e8b15cf3e92084f94f83ce7624d7df1bb25c

commit 8437e8b15cf3e92084f94f83ce7624d7df1bb25c
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Jul 31 18:46:32 2018

[Findit] Remove use of static builder -> trybot mapping.

Everything should now use the single swarming backed variable builder,
and the dimensions for all builders should be obtained by calling the
swarmbucket api.

R=chanli,lijeffrey,stgao,liaoyuke

Change-Id: Id0048aa61e361fbc34cd06905d2ada948819bf5b
Bug: 787918
Reviewed-on: https://chromium-review.googlesource.com/1154029
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/templates/config.html
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/waterfall/waterfall_config.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/test/build_ahead_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/build_ahead.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/try_job.py
[modify] https://crrev.com/8437e8b15cf3e92084f94f83ce7624d7df1bb25c/appengine/findit/services/test_failure/test_try_job.py

Sign in to add a comment