puppet_metrics unsupported operand type error |
|||
Issue description
chromeos-test@chromeos-server99: /var/log/sysmon.log
ERROR:chromite.scripts.sysmon.loop:Error during loop.
Traceback (most recent call last):
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/loop.py", line 34, in loop_once
self._callback()
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/mainlib.py", line 56, in __call__
puppet_metrics.collect_puppet_summary()
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/puppet_metrics.py", line 120, in collect_puppet_summary
for key, value in summary.times.iteritems():
File "/usr/local/google/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/puppet_metrics.py", line 93, in times
times['other'] = max(0, total - sum(times.itervalues()))
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'
,
Nov 22 2017
Did Puppet fail? I see that the run summary file is corrupted, so sysmon breaks. Anyway, I will fix sysmon to handle this case.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d0ab2ca79066a778b23c6f57bfbaf06a70ad1468 commit d0ab2ca79066a778b23c6f57bfbaf06a70ad1468 Author: Allen Li <ayatane@chromium.org> Date: Tue Nov 28 06:50:43 2017 sysmon: Fix default type TypeError BUG= chromium:787904 TEST=None Change-Id: Ibc2e48f04c130ba750f901d995deecdb34803348 Reviewed-on: https://chromium-review.googlesource.com/786430 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/d0ab2ca79066a778b23c6f57bfbaf06a70ad1468/scripts/sysmon/puppet_metrics.py
,
Dec 28 2017
,
Jul 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xixuan@chromium.org
, Nov 22 2017