New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787897 link

Starred by 1 user
Status: Fixed
Owner:
█ amp@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Casting local media fails if not already on New Tab Page

Project Member Reported by amp@chromium.org, Nov 22 2017 
Chrome: 64.0.3260.2
MR: 6417.1106.0.0
Platform: All Win 8, 10, and Mac

*Does not occur on Chrome 63

Repro steps:
1. start Chrome with the --enable-features=EnableCastLocalMedia flag
2. browse to vimeo.com/watch (any site will do other than the New Tab Page)
3. open the cast dialog, and in the drop down menu, select "Cast file"
4. Choose a media file from the file menu
5. Select a device from the device list

Expected: Casting succeeds

Actual: A new tab opens playing the local media file, but Casting doesn't start (sender dialog does not show any active session, and nothing happens on receiver)

*If in step 2, you are on a New Tab Page, then casting succeeds.

Comment 1 by amp@chromium.org, Nov 22 2017

Status: Fixed (was: Started)
commit e064a33b9d8d0ce54a1b0a0d5eadb021709669c6
Author: Adam Parker <amp@chromium.org>
Date:   Wed Nov 22 18:39:18 2017

    [Media Router] Remove source id check when getting provider from sink id.
    
    This fixes local media casting not starting when not on a new tab.
    
    Bug: b/69114456
    Change-Id: I3bd42561be7924fe2217175183a335c46488bd71
    Reviewed-on: https://chromium-review.googlesource.com/779669
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Adam Parker <amp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#518688}

M       chrome/browser/media/router/mojo/media_router_mojo_impl.cc
M       chrome/browser/media/router/mojo/media_router_mojo_impl.h
M       chrome/test/media_router/media_router_integration_browsertest.cc

https://chromium-review.googlesource.com/779669

Comment 2 by amp@chromium.org, Nov 22 2017

Labels: -Type-Bug Type-Bug-Regression
►

Sign in to add a comment