Issue metadata
Sign in to add a comment
|
[Profile Button] Regression: The first row is automatically focused |
||||||||||||||||||||||
Issue descriptionChrome Version: Version 64.0.3275.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Click on the Profile Button (2) The first row is automatically focused What is the expected result? What happens instead? It shouldn't be focused automatically. A screencast is attached.
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e717e13a06e58a5a04dea5731fa828e310ff38fc commit e717e13a06e58a5a04dea5731fa828e310ff38fc Author: Patti <patricialor@chromium.org> Date: Thu Nov 23 10:58:55 2017 MacViews/Profile Chooser: No initial focused View when full keyboard access off. Buttons are not focusable on Mac when full keyboard access is turned off. In the |ProfileChooserView|, a button is returned in WidgetDelegate::GetInitiallyFocusedView(), causing Widget::SetInitialFocus() to fail and fall back to focusing the first focusable View instead. This focuses one of the |HoverButtons| in |ProfileChooserView|, which are always focusable despite full keyboard access (see r518213) because they are designed to be used as a menu. However, opening a menu does not typically focus the first menu item on behalf of the user, so avoid this behavior by checking whether full keyboard access is off first. Bug: 787885 Change-Id: Ie1a92879b31720be4921450677bb3cbdf5b77ec5 Reviewed-on: https://chromium-review.googlesource.com/786830 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#518885} [modify] https://crrev.com/e717e13a06e58a5a04dea5731fa828e310ff38fc/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
Nov 23 2017
Thanks for fixing that bug.
,
Nov 23 2017
Thanks mehmet@ for always filing them! It is much appreciated :)
,
Nov 24 2017
Verified this issue on MacBook Air 10.12.6 using chrome latest canary #64.0.3277.0 following steps mentioned in the original comment. Observed no default focus in the first row after clicking profile button as expected, hence adding TE-Verified label for M64. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Nov 23 2017Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)