New issue
Advanced search Search tips

Issue 787885 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Profile Button] Regression: The first row is automatically focused

Project Member Reported by meh...@chromium.org, Nov 22 2017

Issue description

Chrome Version: Version 64.0.3275.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Click on the Profile Button
(2) The first row is automatically focused


What is the expected result? What happens instead?
It shouldn't be focused automatically.

A screencast is attached.


 
profile_button.mov
254 KB Download
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-64 Needs-Triage-M64
Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on mac 10.12.6 non retina using chrome reported version #64.0.3275.0. Issue is specific to mac non retina.

Bisect Information:
=====================
Good build: 64.0.3274.0    Revision(518061)
Bad Build : 64.0.3275.0    Revision(518486)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/a65bd9a1eb35ad0259c271702dcb27b0e845fe08..f168a3d0f47f69345d88b462b1b73e429ee7dd6e

From the above change log suspecting below change
Change-Id: I7692b052886974389d45bb176c71f34d94eb269c
Reviewed-on: https://chromium-review.googlesource.com/781301

patricialor@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding label ReleaseBlock-Stable as it seems to be a recent regression.

Thanks...!!
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e717e13a06e58a5a04dea5731fa828e310ff38fc

commit e717e13a06e58a5a04dea5731fa828e310ff38fc
Author: Patti <patricialor@chromium.org>
Date: Thu Nov 23 10:58:55 2017

MacViews/Profile Chooser: No initial focused View when full keyboard access off.

Buttons are not focusable on Mac when full keyboard access is turned off. In the
|ProfileChooserView|, a button is returned in
WidgetDelegate::GetInitiallyFocusedView(), causing Widget::SetInitialFocus() to
fail and fall back to focusing the first focusable View instead. This focuses
one of the |HoverButtons| in |ProfileChooserView|, which are always focusable
despite full keyboard access (see r518213) because they are designed to be used
as a menu. However, opening a menu does not typically focus the first menu item
on behalf of the user, so avoid this behavior by checking whether full keyboard
access is off first.

Bug:  787885 
Change-Id: Ie1a92879b31720be4921450677bb3cbdf5b77ec5
Reviewed-on: https://chromium-review.googlesource.com/786830
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518885}
[modify] https://crrev.com/e717e13a06e58a5a04dea5731fa828e310ff38fc/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 3 by jlebel@chromium.org, Nov 23 2017

Thanks for fixing that bug.
Status: Fixed (was: Assigned)
Thanks mehmet@ for always filing them! It is much appreciated :)
Labels: TE-Verified-M64 TE-Verified-64.0.3277.0
Verified this issue on MacBook Air 10.12.6 using chrome latest canary #64.0.3277.0 following steps mentioned in the original comment. Observed no default focus in the first row after clicking profile button as expected, hence adding TE-Verified label for M64.

Thanks!
Screen Shot 2017-11-24 at 2.36.47 PM.png
36.0 KB View Download

Sign in to add a comment