New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787853 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 755761



Sign in to add a comment

NTP: Second row of tiles vanishes at some zoom levels

Project Member Reported by treib@chromium.org, Nov 22 2017

Issue description

- Open NTP (local or remote)
- Zoom to 110%
- Watch the second row of tiles disappear for no apparent reason

Other zoom levels seem to be fine: 125%, 150%, 175% all look good. I can't zoom in further on my screen without making the tiles actually go offscreen.

Probably this is some rounding error, making css think the second row won't fit.
 
Labels: zine-triaged

Comment 2 by treib@chromium.org, Nov 23 2017

Labels: -Type-Bug Type-Bug-Regression

Comment 3 by treib@chromium.org, Nov 23 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db4d9cafba001cff945a5148a8731f7df345a169

commit db4d9cafba001cff945a5148a8731f7df345a169
Author: Marc Treib <treib@chromium.org>
Date: Thu Nov 23 12:19:09 2017

NTP: Fix second row of tiles at non-default zoom levels

Turns out rounding errors at non-100% zoom levels can cause the height
of the MV iframe to get slightly messed up, so it'll fail its @media
min-height checks and incorrectly hide the second row. As a workaround,
give it half a px of tolerance.

Bug:  787853 , 755761
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I78e1211acf2684ee294826c453e8762e344ccdf1
Reviewed-on: https://chromium-review.googlesource.com/787431
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518901}
[modify] https://crrev.com/db4d9cafba001cff945a5148a8731f7df345a169/chrome/browser/resources/local_ntp/most_visited_single.css

Comment 5 by treib@chromium.org, Nov 23 2017

Status: Fixed (was: Started)

Sign in to add a comment