Panning image on twitter brings up refresh affordance and refreshes page |
||
Issue descriptionChrome Version: 62.0.3202.84 OS: Android 8.0.0 What steps will reproduce the problem? (1) Navigate to https://mobile.twitter.com/ (2) Tap on a picture from a post to open the full-page viewer. (3) Pinch zoom on the picture. (4) Pan up. What is the expected result? Expect just the image to pan. What happens instead? Instead, the refresh affordance comes down from the top and if you pull too far and release in addition to panning the image the page will be refreshed. Is this possibly a document event listener which has been made passive? Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 23 2017
Looks like they have touch handlers on the body that record the touches and then apply a transform based on them at rAF. The touch handlers are indeed passive and I get console errors about trying to preventDefault in a passive listener. I don't think that's the (only) problem though. Removing the listeners leaves some vertical scrolling still around but parts of the image cut off and unreachable. So the panning must use some combination of scrolling and transform. This means that we'll be activating the refresh once the pan reaches the top of the scrollable area but it'll continue to transform the image down even as the refresh affordance begins. I don't think there's a bug in Chrome here and I'm not sure we can do anything about it.
,
Nov 23 2017
Wow, weird. Are they perhaps trying to use browser scrolling but JS-based zooming? How does it feel if you just stick a touch-action: none on the page?
,
Nov 23 2017
No, that's what I thought at first but it looks like they have overflow-x: hidden - it seems strange to want vertical scrolling but horizontal panning. It's not viewport scrolling either so it's not for the URL bar. I suspect it's just accidental - they probably didn't expect vertical overflow. touch-action: none does make it feel much better - and fixes the pull-to-refresh issue, perhaps we can reach out to someone from twitter to get them to do that instead? FWIW, Firefox behaves the same way (scrolling while transforming) but it's less of an issue there since they don't have the P2R feature. Panning around doesn't stick to the finger though. |
||
►
Sign in to add a comment |
||
Comment 1 by pnangunoori@chromium.org
, Nov 23 2017Labels: Needs-triage-Mobile Triaged-Mobile M-64