viz: Fix GpuVSyncBeginFrameSource with --enable-viz |
|||||
Issue descriptionOn Windows GpuVSyncBeginFrameSource is used in the browser process with an external BeginFrameSource signal from the GPU process. A message is sent over the command buffer from GPU to browser process that ticks the GpuVSyncBeginFrameSource. With --enable-viz an ExternalBeginFrameSource will be running in the GPU process. The BeginFrame signal will not have to travel over the command buffer, since the signal and ExternalBeginFrameSource are in the same process. The signal will come from the GPU thread (this might be wrong?) and the ExternalBeginFrameSource will be on the compositor thread.
,
Dec 4 2017
The D3DVsync feature isn't enabled by default. There is more information in crbug.com/704794.
,
Dec 14 2017
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb5a6945b8fb8fed66f02f067a5f81c22050b8a6 commit fb5a6945b8fb8fed66f02f067a5f81c22050b8a6 Author: kylechar <kylechar@chromium.org> Date: Mon May 14 18:51:53 2018 Disable D3DVsync with OOP-D. The D3DVsync feature doesn't work with OOP-D, so don't try to use it at the same time. GpuVSyncProviderWin can be simplified with OOP-D as it's just an ExternalBeginFrameSource essentially without the process boundary. Bug: 787814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I814671841df65fcd3141bcfa2ca9db8ea745ea0b Reviewed-on: https://chromium-review.googlesource.com/1057846 Reviewed-by: Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#558390} [modify] https://crrev.com/fb5a6945b8fb8fed66f02f067a5f81c22050b8a6/gpu/ipc/service/BUILD.gn [modify] https://crrev.com/fb5a6945b8fb8fed66f02f067a5f81c22050b8a6/gpu/ipc/service/DEPS [modify] https://crrev.com/fb5a6945b8fb8fed66f02f067a5f81c22050b8a6/gpu/ipc/service/image_transport_surface_win.cc
,
Jun 7 2018
GpuVsyncProviderWin got deleted in https://crrev.com/c/1065808. I think we might want to revive some of that code to implement a D3D BeginFrameSource with OOP-D.
,
Sep 12
It's no longer a priority to revive this code. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by briander...@chromium.org
, Nov 27 2017Components: Internals>GPU>Scheduling