Issue metadata
Sign in to add a comment
|
49.6% regression in blink_perf.canvas at 517853:517904 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8962219026401317968
,
Nov 22 2017
=== BISECT JOB RESULTS === NO Perf regression found, tests failed to produce values Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : blink_perf.canvas Metric : createImageBitmapFromImageData/createImageBitmapFromImageData Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8962219026401317968 For feedback, file a bug with component Speed>Bisection
,
Nov 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8962037114692523696
,
Nov 24 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : blink_perf.canvas Metric : createImageBitmapFromImageData/createImageBitmapFromImageData Revision Result N chromium@517818 79.1919 +- 0.450851 2 good chromium@517889 39.6929 +- 0.0679075 3 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8962037114692523696 For feedback, file a bug with component Speed>Bisection
,
Nov 30 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dbe866ad7f51475007f46673253ed934179529 commit 02dbe866ad7f51475007f46673253ed934179529 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Mon Dec 04 21:55:48 2017 Address canvas perf regressions in createImageBitmapFromImageData This change tries to address the perf regression reported for createImageBitmapFromImageData canvas perf test. This change performs the premul operation in ImageData in advance, instead of doing that after creating the ImageBitmap. This has resulted in ~60% perf improvement on the local Linux machine, so it hopefully must address the regressions. Bug: 782813 , 787772 , 787811 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If0f02d99677348d49cc9d16e910113b4250afb69 Reviewed-on: https://chromium-review.googlesource.com/802855 Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#521476} [modify] https://crrev.com/02dbe866ad7f51475007f46673253ed934179529/third_party/WebKit/Source/core/html/ImageData.cpp [modify] https://crrev.com/02dbe866ad7f51475007f46673253ed934179529/third_party/WebKit/Source/core/html/ImageData.h [modify] https://crrev.com/02dbe866ad7f51475007f46673253ed934179529/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp [modify] https://crrev.com/02dbe866ad7f51475007f46673253ed934179529/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.h [modify] https://crrev.com/02dbe866ad7f51475007f46673253ed934179529/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h
,
Dec 5 2017
,
Jan 19 2018
Issue 787810 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 22 2017