New issue
Advanced search Search tips

Issue 787809 link

Starred by 1 user
Status: WontFix
Owner:
eladalon@chromium.org
Closed: Mar 2018
Cc:
guidou@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Known issue in WebRtcEventLogManagerTest.LocalLogMayNotBeStartedTwice

Project Member Reported by eladalon@chromium.org, Nov 22 2017 
The test checks that a local-log cannot be started twice (without a stop in between). For the current implementation (as of the time of opening this bug), this correctly catches a DCHECK in the UUT (unit under test):
  DCHECK(local_logs_.find({render_process_id, lid}) == local_logs_.end());
However, even if a bug were introduced, and this DCHECK removed, the test would still pass. The problem is likely due to having multiple processes (due to the death-test's fork) and file ownership.

Comment 1 by mattcary@chromium.org, Dec 1 2017

Labels: -Pri-3 Pri-2
Worse, this test seems to be flaking.

Disabling.

Comment 3 by mattcary@chromium.org, Dec 1 2017 

Thanks for disabling. Note that this test seems to be failing on more than just win7
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61506017f35374ac1b2ac94dba19b348f53c2c12

commit 61506017f35374ac1b2ac94dba19b348f53c2c12
Author: Elad Alon <eladalon@chromium.org>
Date: Tue Dec 12 08:45:54 2017

Avoid WebRTC event log messages when not needed

WebRtcEventLogManager needs to be aware of all peer connections, so
that it may start/stop WebRTC event logging on a per peer connection
basis. This is needed because we only want WebRTC sending RTC event
logs back to Chrome, when Chrome intends to log them. For that reason,
we move the logic from WebRTCEventLogHost into WebRtcEventLogManager,
which will know when these event logs are needed (either for local
or for remote logging).

Bug: 775415,  787809 ,  787938 ,  791022 
Change-Id: I4fda5269765d510c69ce6061a0a5bce3125ffc5f
Reviewed-on: https://chromium-review.googlesource.com/811647
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523377}
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/BUILD.gn
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/media/peer_connection_tracker_host.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/media/peer_connection_tracker_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host.cc
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host.h
[delete] https://crrev.com/aa9797217b7f06bb03dee3ca532b60c21703cc97/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/browser/webrtc/webrtc_internals_unittest.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/browser/render_process_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/61506017f35374ac1b2ac94dba19b348f53c2c12/content/test/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/226ae5da35e1cf8da99e551686e020fab613c15f

commit 226ae5da35e1cf8da99e551686e020fab613c15f
Author: maxmorin <maxmorin@chromium.org>
Date: Tue Jan 02 12:50:43 2018

Disable all WebRtcInternalsTests.

These tests are now very flaky.

Bug: 775415,  787809 ,  787938 ,  791022 ,  796047 
Tbr: phoglund@chromium.org
Notry: True
Change-Id: I3ace2542e573d533aab6cfbc1558e4a7ebccce30
Reviewed-on: https://chromium-review.googlesource.com/846882
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526466}
[modify] https://crrev.com/226ae5da35e1cf8da99e551686e020fab613c15f/content/browser/webrtc/webrtc_internals_unittest.cc

Comment 6 by eladalon@chromium.org, Mar 29 2018

Status: WontFix (was: Untriaged)
The design has changed to the point that this test no longer exists.
►

Sign in to add a comment