New issue
Advanced search Search tips

Issue 787803 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 777555



Sign in to add a comment

Direct-leak in av_malloc

Project Member Reported by ClusterFuzz, Nov 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6280633302384640

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  av_malloc
  ff_alloc_extradata
  opus_header
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=425682:425723

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6280633302384640

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 22 2017

Labels: Test-Predator-Auto-Owner
Owner: olka@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/fa7d7d9413d0e3324e25cdb8d67ed87cf7f94acd (Setting device authorization timeout to 2000 ms on MAC).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by olka@chromium.org, Nov 22 2017

Labels: Test-Predator-Wrong-CLs
Owner: ----
CL in #1 is Mac-only.

Comment 3 by olka@chromium.org, Nov 22 2017

Status: Untriaged (was: Assigned)
Cc: kkaluri@chromium.org
Components: Internals>Media>FFmpeg
Labels: M-63
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
As per related   Issue 786803  , assigning it to its concern owner

dalecurtis@-- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You...
Blocking: 777555
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/415212d7045bc6c2ed5c58ec46740251c32ea7ce

commit 415212d7045bc6c2ed5c58ec46740251c32ea7ce
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Nov 29 01:10:35 2017

Roll FFmpeg and update FFmpegDemuxer for security fixes.

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/9cb03e5705c1..18c815f81428

$ git log 9cb03e570..18c815f81 --date=short --no-merges --format='%ad %ae %s'
2017-11-28 dalecurtis Update chromium patches README with new patches.
2017-11-28 dalecurtis Free opus extradata before reallocating.
2017-11-28 dalecurtis Don't manipulate duration when it's AV_NOPTS_VALUE.
2017-11-28 dalecurtis Respect AVERROR codes returned by ogg parsers.
2017-11-25 michael avformat/aacdec: Fix leak in adts_aac_read_packet()

Inspection of code reveals that we don't properly ignore invalid codec
parameters when setting up the ffmpeg demuxer, so we will now explicitly
discard streams which don't have a codec detected.

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 788550 , 787803 , 773637 , 787351 
TEST=ubsan/asan no longer fail.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I87b0482499e41b2c0190ef3852ed81c3e91c4236
Reviewed-on: https://chromium-review.googlesource.com/794844
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519941}
[modify] https://crrev.com/415212d7045bc6c2ed5c58ec46740251c32ea7ce/DEPS
[modify] https://crrev.com/415212d7045bc6c2ed5c58ec46740251c32ea7ce/media/filters/ffmpeg_demuxer.cc

Project Member

Comment 7 by ClusterFuzz, Nov 29 2017

ClusterFuzz has detected this issue as fixed in range 519911:519945.

Detailed report: https://clusterfuzz.com/testcase?key=6280633302384640

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  av_malloc
  ff_alloc_extradata
  opus_header
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=425682:425723
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=519911:519945

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6280633302384640

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6280633302384640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment