New issue
Advanced search Search tips

Issue 787794 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 22
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate need for Profile/ChromeBrowserState to know about every service that it is embedding

Project Member Reported by blundell@chromium.org, Nov 22 2017

Issue description

cf. the discussion on https://chromium-review.googlesource.com/c/chromium/src/+/776797/4:

Q: Is this the pattern that is going to be used for all services? Add a method to create the instance to chrome_browser_state_impl.cc? Isn't this is a step back from KeyedServices?

A: This is a great question. You can think of this stage as being a rough analogue of ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServicesBuilt(). *Something* needs to register all the services that are embedded in the chrome_browser service. We could certainly add a generic interface to ChromeBrowserState that adds a registration function; that interface would have to be invoked before this call to BrowserState::RegisterServices() is made. However, that just pushes the problem somewhere else: What is going to invoke that interface for e.g. the Identity Service to ensure that the Identity Service is registered with this ChromeBrowserState?
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 22

Status: Archived (was: Available)
This issue has been available for more than 365 days with no owner or cc list, so archiving this bug. Please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment