New issue
Advanced search Search tips

Issue 787787 link

Starred by 1 user
Status: Fixed
Owner:
julien.isorce@chromium.org
Closed: Dec 2017
Cc:
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

dri driver path is currently hardcoded whereas it can be extracted from dri.pc

Project Member Reported by julien.isorce@chromium.org, Nov 22 2017 
dri driver path is currently hardcoded so it does not work across various linux platforms and distributions.

Instead it should be extracted from the variable 'dridriverdir' in dri.pc
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b66235077eacfe1691135cd8b1b1a06728cdf810

commit b66235077eacfe1691135cd8b1b1a06728cdf810
Author: Julien Isorce <julien.isorce@chromium.org>
Date: Tue Nov 28 12:20:40 2017

Add //build/config/linux/dri to extract path to dri drivers

The dri drivers path is the variable 'dridriverdir' in 'dri.pc'

If found then translate it to the macro DRI_DRIVER_DIR.

It can be useful in various places instead of guessing the path.
For now only use it in gpu_sandbox_hook_linux except for ChromeOS.

Bug:  787787 
Change-Id: I7fef8606a4f2cbc04233af820a91cf12a4c7a9a5
Reviewed-on: https://chromium-review.googlesource.com/785371
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519658}
[add] https://crrev.com/b66235077eacfe1691135cd8b1b1a06728cdf810/build/config/linux/dri/BUILD.gn
[modify] https://crrev.com/b66235077eacfe1691135cd8b1b1a06728cdf810/build/config/linux/pkg-config.py
[modify] https://crrev.com/b66235077eacfe1691135cd8b1b1a06728cdf810/build/dotfile_settings.gni
[modify] https://crrev.com/b66235077eacfe1691135cd8b1b1a06728cdf810/content/gpu/BUILD.gn
[modify] https://crrev.com/b66235077eacfe1691135cd8b1b1a06728cdf810/content/gpu/gpu_sandbox_hook_linux.cc

Comment 2 by julien.isorce@chromium.org, Dec 4 2017

Components: Internals>GPU>Internals
Labels: Chromecast GPU-Other
Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/797940

Comment 3 by julien.isorce@chromium.org, Dec 4 2017

Labels: OS-Linux
►

Sign in to add a comment