Issue metadata
Sign in to add a comment
|
Regression:Extra padding is observed from Right Hand Side in blocked cookies bubble.
Reported by
shruti.j...@etouch.net,
Nov 22 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3275.0 (Official Build) 57df29264aaef643e8c48bead8701bacd94d1fbc-refs/heads/master@{#518486}(64-bit) OS: Win(7,8,10). Pre-Condition: Enable "Material Design in the rest of the browser's native UI" flag. Test-URL:https://www.google.com/gmail/about/# Steps to reproduce: 1.Launch chrome, go to above link and click on Security chip. 2.On view site info bubble click on cookies link. 3.On cookies overlay, block one of the cookies. 4.Click on cookies icon in omnibox and observe the bubble. Actual Result: Extra padding is observed from Right Hand Side in blocked cookies bubble. Expected Result:Padding should be proper from Right Hand Side in blocked cookies bubble. This is regression issue broken in ‘M-60’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 60.0.3080.0(Revision: 466838). Bad Build: 60.0.3081.0(Revision:467177). You are probably looking for a change made after 467030 (known good), but no lat er than 467031 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds migh t get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/aeb180b1bc8066c2095c124d55 e744be0124f020..ce9d455e92cf41f171d31093cee055e41d634ea9 Suspect:https://chromium.googlesource.com/chromium/src/+/ce9d455e92cf41f171d31093cee055e41d634ea9 @ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Nov 22 2017
,
Nov 29 2017
Fix uploaded: <https://chromium-review.googlesource.com/c/chromium/src/+/796452> Here are screenshots of pre-Harmony and Harmony modes of one of these bubbles.
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12d3545cdca172bf6e8f1fb7e831a2d12c916f26 commit 12d3545cdca172bf6e8f1fb7e831a2d12c916f26 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Dec 06 17:17:33 2017 views: fix content setting bubble width This change: 1) Allows the text labels on checkboxes and radiobuttons to line-wrap instead of truncating; 2) Forces the content setting bubbles to the smallest width in Harmony mode. Bug: 787755 Change-Id: I7c823bc7e0c504935cbd210893001c1ff8c060ec Reviewed-on: https://chromium-review.googlesource.com/796452 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#522119} [modify] https://crrev.com/12d3545cdca172bf6e8f1fb7e831a2d12c916f26/chrome/browser/ui/views/content_setting_bubble_contents.cc [modify] https://crrev.com/12d3545cdca172bf6e8f1fb7e831a2d12c916f26/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/12d3545cdca172bf6e8f1fb7e831a2d12c916f26/ui/views/controls/button/checkbox.h
,
Dec 6 2017
,
Dec 7 2017
Note: Retested the above issue on latest Chrome canary build# 65.0.3287.0 on Win(7,8,10),Mac OS X(10.12.6,10.13.1),Linux(14.04 LTS) and fix is working as intended. Kindly refer the attached screen cast. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Nov 22 2017