New issue
Advanced search Search tips

Issue 787736 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 768705



Sign in to add a comment

Fix inconsistency of default encoding between WorkerScriptLoader and ServiceWorkerInstalledScriptsManager

Project Member Reported by horo@chromium.org, Nov 22 2017

Issue description

WorkerScriptLoader is using UTF8 as a default encoding.
But currently ServiceWorkerInstalledScriptsManager is using latin1 as a default encoding.

If we create the V8 code cache for the first execution of the service worker,
this inconsistency causes SOURCE_MISMATCH failure in SerializedCodeData::SanityCheck() in the second execution.

 

Comment 1 by horo@chromium.org, Nov 22 2017

Blocking: 768705
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec3780d41eba72e398e2984382330984ce7f347a

commit ec3780d41eba72e398e2984382330984ce7f347a
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Nov 22 09:53:54 2017

Use UTF8 as a default in ServiceWorkerInstalledScriptsManager

WorkerScriptLoader is using UTF8 as a default encoding.
But currently ServiceWorkerInstalledScriptsManager is using latin1 as a default encoding.

Bug:  787736 
Change-Id: I5a871fd87b994ad4d439f822e9254ca5df3af76b
Reviewed-on: https://chromium-review.googlesource.com/784741
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518589}
[modify] https://crrev.com/ec3780d41eba72e398e2984382330984ce7f347a/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/ec3780d41eba72e398e2984382330984ce7f347a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerInstalledScriptsManager.cpp

Comment 3 by horo@chromium.org, Nov 22 2017

Status: Fixed (was: Started)

Sign in to add a comment