New issue
Advanced search Search tips

Issue 787702 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
wutao@chromium.org
satorux@chromium.org
jamescook@chromium.org
ovanieva@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 787689


Sign in to add a comment

ChromeOS Keyboard Overlay needs an integration test

Project Member Reported by thestig@chromium.org, Nov 22 2017 
We should have a test that sends a SHOW_KEYBOARD_OVERLAY action and then makes sure:

- the overlay actually comes up
- it doesn't leak memory

Comment 1 by jamescook@chromium.org, Nov 27 2017

Cc: satorux@chromium.org
+satorux

Comment 2 by satorux@chromium.org, Nov 28 2017

Cc: ovanieva@chromium.org wutao@chromium.org
I thought the keyboard overlay will be replaced with Keyboard Shortcut Helper?

Comment 3 by wutao@chromium.org, Nov 28 2017 

New Keyboard Shortcut Helper is targeted at M65.
https://bugs.chromium.org/p/chromium/issues/detail?id=755448

Comment 4 by thestig@chromium.org, Nov 28 2017 

We can consider this a request for the replacement as well. :)

Should I try to fix bug 787689 then? I actually want to investigate it anyway, as it is not obvious why it is leaking, and other ui::WebDialogDelegate objects may be leaking as well.

Comment 5 by weifangsun@chromium.org, Dec 1 2017

Components: -UI>Shell UI>Input>KeyboardShortcuts

Comment 6 by ovanieva@chromium.org, Dec 1 2017

Status: WontFix (was: Untriaged)
thestig@ we are going to depricate keyboard shortcut overlay in M65 and replace it with new keyboard shortcut helper. Not sure it's worth looking into issue you described in bug 787689.
►

Sign in to add a comment