New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787693 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Network requests should have "Copy as PowerShell" option in the context menu on Windows

Reported by bel...@gmail.com, Nov 22 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Steps to reproduce the problem:
1. Open the "Network" tab of devtools
2. Right click on any request
3. Open the "Copy" submenu

What is the expected behavior?

What went wrong?
There is an option to copy request as cURL command, but cURL is a third-party software which may or may not be installed on the user's machine.
PowerShell is present on all Windows 7+ installations and has the functionality to issue web requests. 

Did this work before? No 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 10.0
Flash Version: 27.0.0.187

The patch to add the PowerShell support is on its way.
 
Cc: sc00335...@techmahindra.com
Components: -Platform>DevTools Platform>DevTools>Network
Labels: -Type-Bug Triaged-ET M-64 Needs-Triage-M62 Type-Feature
Status: Untriaged (was: Unconfirmed)
As per comment#0 considering this issue as Feature Request and marking this as Untriaged.

Thanks!
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
I believe allada@ is reviewing external contribution for this one.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc40f64e71b144cdb2410621b012b28eed776706

commit bc40f64e71b144cdb2410621b012b28eed776706
Author: Ilia Demianenko <ilia.demianenko@gmail.com>
Date: Sat Dec 02 00:18:52 2017

DevTools: Add "Copy as PowerShell" option for network requests

PowerShell is a powerful command-line shell which is preinstalled on all
Windows 7+ machines and is capable of issuing arbitrary network
requests. This change adds two options to the network request context
menu on Windows systems: "Copy as PowerShell" and "Copy all as
PowerShell".

Testing done: strings from the old curl-command.html and the Big List of
Naughty Strings (https://github.com/minimaxir/big-list-of-naughty-strings)
were submitted as request URL and bodies. Requests then were copied,
submitted from PowerShell and cURL (bash) and compared on the server side.
All requests got byte-for-byte match.

Bug:  787693 
Change-Id: I1a404e0a127cc27f154ad965661fb227232a0b08
Reviewed-on: https://chromium-review.googlesource.com/784770
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521141}
[modify] https://crrev.com/bc40f64e71b144cdb2410621b012b28eed776706/AUTHORS
[modify] https://crrev.com/bc40f64e71b144cdb2410621b012b28eed776706/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Labels: TE-Verified-M65 TE-Verified-65.0.3284.0
Tested this issue on Windows 7 using the latest Canary 65.0.3284.0 by following the steps mentioned in the original comment.

Can observe the option "Copy as PowerShell" in Devtools -> Network -> Right-click on any request -> Copy
Attached is the screen shot for reference.

Hence adding TE-Verified labels as this is working as intended.

Thanks..
Attaching the screen shot.
787693.png
254 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment