New issue
Advanced search Search tips

Issue 787692 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Should NativeThemeWin dtor call CloseHandle() ?

Project Member Reported by thestig@chromium.org, Nov 22 2017 
NativeThemeWin::~NativeThemeWin() has a 5+ year old TODO(cpu) asking if it should call CloseHandle(). Converting the TODO to a bug.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39406bd9b5519aaee5f2dfe4f4360ef218576533

commit 39406bd9b5519aaee5f2dfe4f4360ef218576533
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Nov 22 18:47:09 2017

Update an old NativeThemeWin TODO to point to a bug.

BUG= 787692 

Change-Id: I576d7388580bf14612cfb50d8acef00b20144979
Reviewed-on: https://chromium-review.googlesource.com/784322
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518693}
[modify] https://crrev.com/39406bd9b5519aaee5f2dfe4f4360ef218576533/ui/native_theme/native_theme_win.cc

Comment 2 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 3 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment