New issue
Advanced search Search tips

Issue 787687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup CacheStrategiesForCacheStorage flag

Project Member Reported by horo@chromium.org, Nov 22 2017

Issue description

CacheStrategiesForCacheStorage flag was introduced by https://codereview.chromium.org/1914963002 to do the field experiment (see  issue 581613  and issue 611283).

We don't need this flag anymore.
We should remove it for the code health.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca74a307c745f6f8a1d9b8d83d574966abba641

commit 2ca74a307c745f6f8a1d9b8d83d574966abba641
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Nov 22 14:40:04 2017

Cleanup CacheStrategiesForCacheStorage flag

This CL removes v8-cache-strategies-for-cache-storage flag.

When --v8-cache-options=none is NOT set, V8 code cache for JS file in
CacheStorage is created when the JS file is executed in a page for the first
time.

Bug:  787687 
Change-Id: Idc982b456742253c7f3f3b13dff5c301348564f2
Reviewed-on: https://chromium-review.googlesource.com/784530
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518630}
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/chrome/browser/about_flags.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/content/public/common/content_switches.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/content/public/common/content_switches.h
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/content/renderer/render_view_impl.cc
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/bindings/bindings.gni
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[delete] https://crrev.com/1875561aec80853a98550bc1c7c972906038cec2/third_party/WebKit/Source/bindings/core/v8/V8CacheStrategiesForCacheStorage.h
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/core/frame/Settings.h
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/2ca74a307c745f6f8a1d9b8d83d574966abba641/third_party/WebKit/public/web/WebSettings.h

Comment 2 by jsb...@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)
Done?

Comment 3 by horo@chromium.org, Nov 28 2017

yes. thank you.

Sign in to add a comment