chromite auto roller |
||||||
Issue descriptionA number of projects (catapult, webrtc) have auto-rollers that run a few times daily. We should have one for chromite. Even though it's not particularly burdensome for gardeners to do manual rolls, sometimes we accumulate a few dozen CLs. It should be safe-ish since we have simple chrome builders to catch problems with gn args, and even safer once we have cros vm tests.
,
Mar 1 2018
We could do chromite autorolls whenever we do LKGM commits (approx once a day).
,
Mar 1 2018
I'd prefer not to add that complexity to the PFQ master. CHROMEOS_LKGM makes sense since the PFQ (kind of) validates the cros version. The version of chromite used in the various PFQ stages is... complicated.
,
Mar 2 2018
What a timely bug... I just attended a brown-bag talk about the service behind most of chromium's auto-rollers. It's a single service, owned by the skia team, that's streamlined for low-maintenance and frequent rolls of any number of repos. I think rolling chromite into chromium would be a good use-case for it. (More info at https://docs.google.com/presentation/d/1ATqfAirhXibbMUEn750ktLY_qef5eVD5refpfBRO0Wo) What do we think of configuring it to handle chromite rolls?
,
Mar 2 2018
In general, SGTM. We've been rolling it manually ~weekly which seems fine. If there is away to email notify the current gardener or even the gardener list, that would be great!
,
Mar 2 2018
This is definitely something we can do! We have support for various types of throttling, so you can limit to one successful roll per N hours/days/whatever. If you're interested, please fill out a request at http://go/new-autoroller.
,
Mar 2 2018
Thanks Eric, I'll work on doing that.
,
Mar 16 2018
The auto-roller's set up and ready to go: (thanks to Eric for standing it up) https://chromite-chromium-roll.skia.org/# It's currently paused. Achuith/Steven, any reason not to enable it?
,
Mar 16 2018
No, feel free to let it run. Looks like it did the right thing with the last roll.
,
Mar 16 2018
sgtm
,
Mar 19 2018
We've had 4 rolls, and this looks like it's working. I'll close this bug and we can open a new one if we find any issues. Thanks for setting this up, Ben!
,
Mar 19 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by steve...@chromium.org
, Mar 1 2018Labels: Hotlist-CrOS-Gardener