New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787676 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Stop parsing urls for tryjobs on findit, instead provide an api on luci to get the appropriate information.

Project Member Reported by robert...@chromium.org, Nov 22 2017

Issue description

Findit relies on a set of hardcoded regexes to get the master, builder and buildnumber for builds and tryjobs.

Instead of trusting this fragile hardcoded logic, it should instead call an appropriate api to get these parts from.
 

Comment 1 by no...@chromium.org, Nov 22 2017

Wherever FindIt gets build URLs, master, builder and build number should be there too. Where does FindIt gets build URLs from?

Comment 2 by st...@chromium.org, Nov 22 2017

1. From user input (less often, mostly for ourself to test), copy & paste a url to a failed build is convenient than selecting master/builder and paste a build number IMHO.
2. From SoM, but just the master url.
3. Also used to be from chromium-try-flakes, but CTF is not working now. So out of scope I think.

Comment 3 by no...@chromium.org, Nov 22 2017

1) looks like FindIt is willing to accept non-structure input for the sake of good UX. Then, IMO, that UI and only that UI should have the logic for parsing unstructured input. The rest of the FindIt should deal with structured data 
2) sounds like SoM API should be improved, so that FindIt gets more structured response

Comment 4 by st...@chromium.org, Nov 22 2017

That makes sense, and thanks for the suggestions!

just think of another one:
4) after a try-job started, buildbucket also returns a build url.

Comment 5 by no...@chromium.org, Nov 22 2017

yes, buildbucket returns build URL, but it also returns master, builder, and build number in "build_address" tag for LUCI builds. The format of build_address is "bucket/builder/build_number" or in future "project/bucket/builder/build_number"
Owner: chanli@chromium.org
Status: Assigned (was: Untriaged)
Chan: you are working on this already, right?

Sign in to add a comment