New issue
Advanced search Search tips

Issue 787675 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 787689



Sign in to add a comment

Some ui::WebDialogDelegate derived delegates are probably leaking

Project Member Reported by thestig@chromium.org, Nov 22 2017

Issue description

ui::WebDialogDelegate::OnDialogClosed() has a comment that says:

IMPORTANT: Implementations should delete |this| here (unless they've arranged for the delegate to be deleted in some other way, e.g. by registering it as a message handler in the WebUI object).

But it's not obvious if all delegate implementations are actually doing this. We should audit them and make it very clear what each delegate's lifetime / memory management model is.
 
Blockedon: 787689

Sign in to add a comment