New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CrashKeyStringTest.FormatStackTrace crashing on chromium.win/Win7

Project Member Reported by mgiuca@chromium.org, Nov 22 2017

Issue description

components_unittests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Crashed on 2/2 runs since this test was added in r518381. Reverting.

[ RUN      ] CrashKeyStringTest.FormatStackTrace
c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\win_sdk\bin\..\..\vc\tools\msvc\14.11.25503\include\xstring(1297) : Assertion failed: cannot seek string iterator before begin
Received fatal exception EXCEPTION_BREAKPOINT
Backtrace:
	base::TestSuite::SuppressErrorDialogs [0x06F180BD+381]
	invalid_parameter [0x7426E551+161]
	std::_String_const_iterator<std::_String_val<std::_Simple_types<char> > >::operator+= [0x024505DA+426]
	std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator+= [0x02450405+37]
	std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator-= [0x0664771F+31]
	std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator- [0x066476A0+80]
	std::basic_string<char,std::char_traits<char>,std::allocator<char> >::back [0x06647601+65]
	crash_reporter::internal::FormatStackTrace [0x066474E1+353]
	base::internal::DstRangeRelationToSrcRangeImpl<unsigned int,unsigned int,base::internal::SaturationDefaultLimits,0,0,1>::Check [0x037F2219+585]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x04672499+105]
	testing::Test::Run [0x046723A6+182]
	testing::TestInfo::Run [0x0467305A+250]
	testing::TestCase::Run [0x04673D6B+267]
	testing::internal::UnitTestImpl::RunAllTests [0x0467BE42+786]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0467BADE+110]
	testing::UnitTest::Run [0x0467B8D4+324]
	RUN_ALL_TESTS [0x06F17DFF+15]
	base::TestSuite::Run [0x06F17116+150]
	content::UnitTestTestSuite::Run [0x07E44B06+22]
	??$Invoke@ABV?$unique_ptr@VUnitTestTestSuite@content@@U?$default_delete@VUnitTestTestSuite@content@@@std@@@std@@$$V@?$FunctorTraits@P8UnitTestTestSuite@content@@AEHXZX@internal@base@@SAHP8UnitTestTestSuite@content@@AEHXZABV?$unique_ptr@VUnitTestTestSuite@ [0x05BCFCF1+33]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::UnitTestTestSuite::*const &)(void),std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > const &> [0x05BCFC0D+77]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::UnitTestTestSuite::*)(void),std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > >,int __cdecl(void)>::RunImpl<int (__thiscall content::Unit [0x05BCFB9A+74]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::UnitTestTestSuite::*)(void),std::unique_ptr<content::UnitTestTestSuite,std::default_delete<content::UnitTestTestSuite> > >,int __cdecl(void)>::Run [0x05BCFA1E+62]
	base::RepeatingCallback<int __cdecl(void)>::Run [0x06F05A92+50]
	base::LaunchUnitTests [0x06F03955+837]
	base::LaunchUnitTests [0x06F036D0+192]
	main [0x0333CF01+129]
	invoke_main [0x097A650E+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78)
	__scrt_common_main_seh [0x097A63B0+336] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	__scrt_common_main [0x097A624D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
	mainCRTStartup [0x097A6588+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x75DA336A+18]
	RtlInitializeExceptionChain [0x77649902+99]
	RtlInitializeExceptionChain [0x776498D5+54]

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8358924a33bf0bddc08520dff5c3c9f4aa73675e

commit 8358924a33bf0bddc08520dff5c3c9f4aa73675e
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed Nov 22 01:38:51 2017

Revert "Add a utility to format a base::debug::StackTrace for CrashKeyString."

This reverts commit f12be75c72b03200901e84da7a066c4b0a1c9217.

Reason for revert: New test crashes on chromium.win/Win7.
Bug:  787669 

Original change's description:
> Add a utility to format a base::debug::StackTrace for CrashKeyString.
> 
> Bug:  598854 
> Change-Id: Ie92935f4919e57cae338c33750458c0509a93627
> Reviewed-on: https://chromium-review.googlesource.com/782040
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518381}

TBR=rsesek@chromium.org,mark@chromium.org

Change-Id: Ibfa0b31f290fe2f99dc90791b79240b1dd71121d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598854 
Reviewed-on: https://chromium-review.googlesource.com/784170
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518492}
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/BUILD.gn
[delete] https://crrev.com/9a0cfb428cf07e2ccdd2aeb4968c3c323fb3e40e/components/crash/core/common/crash_key.cc
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/crash_key.h
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/crash_key_unittest.cc

Comment 2 by mgiuca@chromium.org, Nov 22 2017

Cc: -rsesek@chromium.org mgiuca@chromium.org
Owner: rsesek@chromium.org
Status: Fixed (was: Started)
Should cycle green.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac34ddc366b5308df6a61b3cf8df4586ee680cb5

commit ac34ddc366b5308df6a61b3cf8df4586ee680cb5
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 28 17:37:21 2017

Reland "Add a utility to format a base::debug::StackTrace for CrashKeyString."

This is a reland of f12be75c72b03200901e84da7a066c4b0a1c9217
Original change's description:
> Add a utility to format a base::debug::StackTrace for CrashKeyString.
>
> Bug:  598854 
> Change-Id: Ie92935f4919e57cae338c33750458c0509a93627
> Reviewed-on: https://chromium-review.googlesource.com/782040
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518381}

Bug:  598854 ,  787669 
Change-Id: I81fef0cba08240ee288d4e3db3c3bcf4ff130219
Reviewed-on: https://chromium-review.googlesource.com/793930
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519727}
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/BUILD.gn
[add] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key.cc
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key.h
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key_unittest.cc

Sign in to add a comment