New issue
Advanced search Search tips

Issue 787637 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Unmerged Console view not available in LUCI UI

Project Member Reported by jam@chromium.org, Nov 21 2017

Issue description

Unless I'm missing something, the familiar UI that shows all changes in waterfall view (i.e. not merged colored lined) and also list the commit's description (i.e. without hover).
 

Comment 1 by hinoka@chromium.org, Nov 22 2017

Which view did you mean by "Waterfall" - 

A: https://screenshot.googleplex.com/dtzdtxaqfNL
or 
B: https://screenshot.googleplex.com/ruQpt3osmcP

Comment 2 by jam@chromium.org, Nov 22 2017

The first one (but that has all the  masters like chromium, win, mac linux, memory etc)

Comment 3 by hinoka@chromium.org, Nov 22 2017

Status: Available (was: Untriaged)
Summary: Unmerged Console view not available in LUCI UI (was: Waterfall view not available in LUCI UI)
Ah I see.  We have a more precise name for that view on our side (B is the one we generally refer to as Waterfall view, since that's what buildbot called it).

Comment 4 by efoo@chromium.org, Nov 22 2017

Cc: jam@chromium.org
Labels: LUCI-Blocker-UI
@jam - this would be our console view. We made some optimizations to the UI to increase information density (https://ci.chromium.org/p/chromium/g/chromium/console)

What in particular in the Buildbot UI do you miss or are we missing something? Is it mainly the ability to see the commit's description? 

Adding label for tracking. 

Comment 5 by efoo@chromium.org, Nov 22 2017

Labels: LUCI-KnownIssues-UI

Comment 6 by jam@chromium.org, Nov 22 2017

I want the same information as before. e.g. changelist info and also to see all the different masters.

You can compare https://chromium-build.appspot.com/p/chromium/console and the link you sent

Comment 7 by estaab@chromium.org, Nov 22 2017

efoo's link should have been https://ci.chromium.org/p/chromium/g/main/console

which has all the masters but we can look into the changelist info since you're not the first to ask for that.

Comment 8 by estaab@chromium.org, Nov 27 2017

jam@, we can add an "Expand" button that will show full changelist info on the left of each row like before but I want to make sure I understand your workflow in case we can do something more forward-looking.

When you use the unmerged view are you scanning for the first red and looking back through the changes for suspicious file edits and commit messages?

Comment 9 by jam@chromium.org, Nov 27 2017

@estaab: I'd like the default load so that it shows the full list. I don't think it's useful by default to not show cl information.

I, and I'm sure other devs, have many different use cases for why we look there. So I'm not sure we should focus on specific use cases, because it can go against others' uses.

Is there a reason why we need to change the UI?
Cc: dpranke@chromium.org
> @estaab: I'd like the default load so that it shows the full list. I don't think it's useful by default to not show cl information.
> I, and I'm sure other devs, have many different use cases for why we look there. So I'm not sure we should focus on specific use cases, because it can go against others' uses.

I understand, but many developers prefer the merged collapsed view and default to that. It's easier to see at what change a transition happened with the increased info density, for instance.

I'm interested in your use case since so far you're the first person on record who has needed it and hasn't been able to use the hover on the merged view (kbr@ wanted it but was happy after discovering hover).

> Is there a reason why we need to change the UI?

The short answer is that we've ported the UI to the cloud platform for a number of reasons that benefit both developers and the ops team and it's a prerequisite to moving the lower levels of our infrastructure to the cloud (i.e. the rest of LUCI). So far we've re-implemented the features we know developers use and will happily implement more if it means we're keeping them productive.

Comment 11 by jam@chromium.org, Nov 28 2017

I often keep the page with the refresh query parameter so I can see what changes are landing. Speaking of, does the refresh parameter work with the new UI?

Also when there's a breakage or failure, I like to be able to read the cl descriptions nearby.

Regarding changing the UI; what I meant is why combine the switch to LUCI UI with also changing the UI? i.e. why not separate these two steps? First switch to LUCI, and then make UI changes as needed.
> Why combine the switch to LUCI UI [Milo] with also changing the UI?

The whole point of LUCI is to move off of buildbot, so we'd either have to recreate the buildbot UI exactly, or change it. Given that there's a bunch of things in the buildbot UI that we don't need (like the waterfall page), and that it's not a great UI in the first place, matching it exactly seems like wasted effort.

That means that then either we change the UI exactly when we move builders off of buildbot (since we'd have to have a new UI somewhere for the non-buildbot builders), or before (by switching everybody to Milo first). We're doing the latter, which is completely consistent with how we've done the other parts of the LUCI migration (like moving to Swarming, Machine Provider, LogDog, and Buildbucket).

The added advantages to moving to the new UI first are that are that it takes load off of buildbot, which makes buildbot more stable, pages load faster (b/c we're not stuck behind the twisted event loop), and we now have a framework that the team is much more comfortable iterating on to add new features (since they don't have to hack buildbot code). In other words, we'd want to move to Milo even if we weren't otherwise ready to move off of buildbot.

Does that make sense?

Comment 13 by jam@chromium.org, Nov 28 2017

@Dirk: thanks for the background.

If the team wants to add a compressed view, I think that's fine but we shouldn't also lose the current view that has more information. Perhaps a setting?

Also I'd like to make sure the refresh option is still available?

Comment 14 by e...@chromium.org, Nov 28 2017

I use the current uncompressed view to skim the current patches. This is really handy for skimming what's currently going into the tree at a glance. I would really prefer to not lose this ability.
Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Sounds good. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=789264 for refresh but won't block launch on it. Keeping expanded view as launch blocking, though.
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/c0d775a3c064d193177aa015a394dedbe4c50fd7

commit c0d775a3c064d193177aa015a394dedbe4c50fd7
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Dec 01 01:23:29 2017

[milo] Console - Add option to expand

This adds unmerged (expanded) view by calculating the height
of the commit message div, and adding spacers between bubbles
to compensate.

Bug:787637
Change-Id: Ied992ce7c40308c11c2ab8094d186feaa185f87d
Reviewed-on: https://chromium-review.googlesource.com/795036
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/api/buildbot/result_string.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/common/model/status_string.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/appengine/static/common/css/console.css
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/appengine/templates/includes/base.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/appengine/templates/pages/console.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.builder-Basic_Test_no_builds.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/console-Full_console_with_Header.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/frontpage-Basic_frontpage.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/search-Basic_search_page.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/expectations/swarming.log-Basic_log.html
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/botstatus_string.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/build.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/componenttype_string.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/console.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/console_test.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/ui/verbosity_string.go
[modify] https://crrev.com/c0d775a3c064d193177aa015a394dedbe4c50fd7/milo/frontend/view_console.go

The option is expand is in.  Next is to make the option sticky via a cookie.

Comment 19 by efoo@chromium.org, Dec 4 2017

Labels: -LUCI-Blocker-UI LUCI-Blocker-M4
Ryan, do you have an update on the sticky changes? 

Removing LUCI-Blocker-UI label, adding to LUCI-Blocker-M4

Comment 20 by efoo@chromium.org, Dec 4 2017

Labels: -LUCI-M0-Backlog LUCI-M3-S12 LUCI-M3-Beta
It's in codereview, almost committed.
Status: Fixed (was: Assigned)
This should be in.  Due to the way the page is laid out (flexbox vs tables), there's some initial jank as the page switched from collapsed to expanded.  Please let me know if this is acceptable.

Comment 24 by jam@chromium.org, Dec 5 2017

Thanks for the fix.

Comment 25 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 26 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M3-Beta luci-blocker-migration

Comment 27 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets

Sign in to add a comment