New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787633 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

session_manager attempts to call vm_launcher even when it's not present

Project Member Reported by smbar...@chromium.org, Nov 21 2017

Issue description

ERR session_manager[18926]: [ERROR:process.cc(329)] Exec of /usr/bin/vm_launcher failed:: No such file or directory

We should either not instantiate TerminaManager, or fail out early if vm_launcher is missing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/faae7ef564e27fea9fb29d932ed6fb2bea4bef3f

commit faae7ef564e27fea9fb29d932ed6fb2bea4bef3f
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Nov 28 06:50:48 2017

login: only attempt to shut down VMs when enabled

Don't unconditionally call vm_launcher when shutting down
session_manager, since it might not exist. If vm_launcher
doesn't exist, then VMs are not enabled.

BUG= chromium:787633 
TEST=sign out of Chrome; no vm_launcher error is printed

Change-Id: Iecdf50df90e76274ef2da33c65c3109cf29e4bb5
Reviewed-on: https://chromium-review.googlesource.com/784119
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/faae7ef564e27fea9fb29d932ed6fb2bea4bef3f/login_manager/termina_manager_impl.cc

Labels: -M-63
Status: Fixed (was: Started)
Components: OS>Systems>Containers

Sign in to add a comment