New issue
Advanced search Search tips

Issue 787623 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 772534



Sign in to add a comment

Limit Net.CertificateTransparency metrics to is_issued_by_known_root=true

Project Member Reported by est...@chromium.org, Nov 21 2017

Issue description

Since CT compliance will only be enforced for publicly trusted roots, our metrics should only cover connections with publicly trusted roots.
 

Comment 1 by est...@chromium.org, Nov 23 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efce783364c333ac8365d331b666b311a9595554

commit efce783364c333ac8365d331b666b311a9595554
Author: Emily Stark <estark@google.com>
Date: Thu Nov 30 03:16:16 2017

Filter CT compliance histograms to public roots

Since CT policies won't be enforced for locally-installed roots, these
histograms aren't of interest in such cases.

Bug:  787623 
Change-Id: Ia64082a218d935c075515e7596bd41f0ba926218
Reviewed-on: https://chromium-review.googlesource.com/786990
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520408}
[modify] https://crrev.com/efce783364c333ac8365d331b666b311a9595554/net/quic/chromium/crypto/proof_verifier_chromium.cc
[modify] https://crrev.com/efce783364c333ac8365d331b666b311a9595554/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/efce783364c333ac8365d331b666b311a9595554/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/efce783364c333ac8365d331b666b311a9595554/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/efce783364c333ac8365d331b666b311a9595554/tools/metrics/histograms/histograms.xml

Comment 3 by est...@chromium.org, Nov 30 2017

Status: Fixed (was: Started)

Sign in to add a comment