New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787622 link

Starred by 2 users
Status: Fixed
Owner:
█ iannucci@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename /admin/settings to /admin/portal to allow non-settings actions to live there.

Project Member Reported by iannucci@chromium.org, Nov 21 2017 
We have need in various appengine apps to put admin 'actions' somewhere.

/admin/settings is almost perfect for this, except that its name indicates that it's for settings. Other application frameworks call these sorts of pages an 'admin portal', so I'd like to rename /admin/settings to /admin/portal (with relevant documentation changes and go package refactors).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/aab8fb08c06fa418063cddc3316341d534f1e367

commit aab8fb08c06fa418063cddc3316341d534f1e367
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Nov 21 23:29:19 2017

[server/portal] Rename server/settings/admin to server/portal.

This will allow us to non-confusingly add other admin portal actions to
these pages (like one-time clear-queue, or generate-token actions).

R=nodir@chromium.org, nodir@google.com, vadimsh@chromium.org, vadimsh@google.com

Bug:  787622 
Change-Id: Ib15e86393b38e66375aaa6f20162b783e241966d
Reviewed-on: https://chromium-review.googlesource.com/783813
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/appengine/gaeauth/server/db.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/appengine/gaeauth/server/default.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/appengine/gaeauth/server/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/appengine/gaemiddleware/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/appengine/gaemiddleware/standard/env.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/examples/appengine/helloworld_standard/README.md
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/logdog/README.md
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/luci_config/appengine/gaeconfig/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/machine-db/appengine/settings/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/scheduler/appengine/devcfg/README.md
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/analytics/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/auth/openid/settings.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/handlers.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/index.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/assets.gen.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/assets_test.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/generate.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/includes/base.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/access_denied.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/done.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/error.html
[add] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/index.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/page.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/pages/validation_error.html
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/third_party/bootstrap/README.md
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/third_party/bootstrap/bootstrap.min.css
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/internal/assets/third_party/bootstrap/config.json
[add] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/page.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/settings.go
[rename] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/portal/yesno.go
[delete] https://crrev.com/278688ab30b6030863d137bb4615f19e77768e9c/server/settings/admin/internal/assets/pages/index.html
[delete] https://crrev.com/278688ab30b6030863d137bb4615f19e77768e9c/server/settings/ui.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/server/tsmon/settings.go
[modify] https://crrev.com/aab8fb08c06fa418063cddc3316341d534f1e367/tumble/settings.go
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/c4369096418cb27f8a6bd073ad1fbad69acc9087

commit c4369096418cb27f8a6bd073ad1fbad69acc9087
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Nov 22 01:04:06 2017
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/491a8bc951c1f259709121d2aa2d4a76d60dcbcd

commit 491a8bc951c1f259709121d2aa2d4a76d60dcbcd
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Tue Nov 28 00:24:27 2017

[portal] Add clickable buttons to portal pages (aka "actions").

They can have a title, a help string and optional confirmation message.

R=iannucci@chromium.org, nodir@chromium.org
BUG= 787622 

Change-Id: I6d338528a4ff3c3ba7f319b9b6a5406195b0ab29
Reviewed-on: https://chromium-review.googlesource.com/784281
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/machine-db/appengine/settings/settings.go
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/handlers.go
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/assets.gen.go
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/includes/base.html
[add] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/pages/action_done.html
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/pages/error.html
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/pages/index.html
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/pages/page.html
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/third_party/bootstrap/bootstrap.min.css
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/third_party/bootstrap/config.json
[add] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/third_party/modal-vanilla/LICENSE
[add] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/third_party/modal-vanilla/README.md
[add] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/internal/assets/third_party/modal-vanilla/modal.min.js
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/page.go
[modify] https://crrev.com/491a8bc951c1f259709121d2aa2d4a76d60dcbcd/server/portal/settings.go

Comment 5 by iannucci@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)
calling this one done

Comment 6 by iannucci@chromium.org, Nov 28 2017

Status: Assigned (was: Fixed)
Actually, reopening until a luci-go roll happens.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/273ef7d9cc6a4ec503b247b89f4ab9d3060564b3

commit 273ef7d9cc6a4ec503b247b89f4ab9d3060564b3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Nov 28 00:46:07 2017

Roll go.chromium.org/luci

infra/go/src/go.chromium.org/luci:
491a8bc9 [portal] Add clickable buttons to portal pages (aka "actions").
6991609f [vpython] Remove deprecated -spec flag.
86f147ab [milo] Allow builder summaries to wrap.
49d125f3 Add drain file support to RunShared()
f6abeb1e [milo] initialize header only if it is defined
1463cce0 [milo] Reduce tree status spacing in console header.
f0ebec43 [Machine Database] Update datacenters to match the config
06568d07 [milo] Make console loading more parallel

R=vadimsh@chromium.org

Bug:  787622 
Change-Id: I1078eccba1d7821bd037322c1777af0247ddca1a
Reviewed-on: https://chromium-review.googlesource.com/791823
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/273ef7d9cc6a4ec503b247b89f4ab9d3060564b3/DEPS

Comment 8 by iannucci@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment