New issue
Advanced search Search tips

Issue 787620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Make the Console filter persistent

Reported by cont...@jaygeorge.co.uk, Nov 21 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3274.0 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools
2. Press Escape to open the console
3. Use the recently added Filter to get rid of things you don't care about
4. Close and re-open DevTools

What is the expected behavior?
The Console filter should persist, or there should be a way to make it persist.

What went wrong?
The Console filter is cleared

Did this work before? No 

Chrome version: 64.0.3274.0  Channel: canary
OS Version: OS X 10.13.1
Flash Version: 

The trouble is that DevTools now shows me loads of interesting information but most of the time I do not want to see this. E.g. it might suggest to me that inputs have autocomplete present with for the Olark Chat plugin. However, I almost always want to filter this information out because it's out of my control and I do not care for Olark advice.
 
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a0229065510c32eacf89277f718f8972b13a95

commit 66a0229065510c32eacf89277f718f8972b13a95
Author: Erik Luo <luoe@chromium.org>
Date: Mon Dec 11 23:26:05 2017

DevTools: persist console text filter and sidebar state

Console will remember
- User text typed in the input filter
- Whether the sidebar was open, consistent with Sources and the drawer
- Which top level sidebar filter was selected

Bug:  787620 ,  734088 
Change-Id: Iab109fbf1f459b0c64974c7414dcf3fd24739f11
Reviewed-on: https://chromium-review.googlesource.com/810090
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523247}
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar.js
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test.js
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/66a0229065510c32eacf89277f718f8972b13a95/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Comment 3 by l...@chromium.org, Dec 11 2017

Status: Fixed (was: Assigned)
Summary: DevTools: Make the Console filter persistent (was: Make the Console filter persistent)
Thanks for the report, sounds like a reasonable request.

Sign in to add a comment