New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 782434



Sign in to add a comment

[Findit] Flake Analyzer - RunFlakeTryJobPipeline should be asynchronous

Project Member Reported by lijeffrey@chromium.org, Nov 21 2017

Issue description

Once MonitorTryJobPipeline is refactored into services, RunFlakeTryJobPipeline should become an asynchronous pipeline and handle monitoring as well
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f

commit cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f
Author: Jeffrey Li <lijeffrey@google.com>
Date: Mon Jan 29 06:30:45 2018

[Findit] Flake Analyzer - RunFlakeTryJobPipeline Async

Prior to this change, RunFlakeTryJobPipeline only triggers the try job but does not handle
monitoring/retrieving results. RunFlakeTryJobPipeline is now Asynchronous and uses callbacks
to return the resulting isolate sha in the try job result.

Bug:  787618 
Change-Id: Iea5fa83d36de8ceb581e140fc693d90059f9038a
Reviewed-on: https://chromium-review.googlesource.com/811686
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/flake_failure/run_flake_try_job_pipeline.py
[add] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/dto/flake_try_job_report.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/services/flake_failure/flake_try_job.py
[add] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/dto/isolated_tests.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/services/parameters.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/test_failure/run_test_try_job_pipeline.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/compile_failure/run_compile_try_job_pipeline.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/dto/__init__.py
[add] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/dto/flake_try_job_result.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/compile_failure/test/run_compile_try_job_pipeline_test.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/services/try_job.py
[modify] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/pipelines/flake_failure/test/run_flake_try_job_pipeline_test.py
[add] https://crrev.com/cfdf7b0e5212e8d35f8e7f646ceb0f338dd04e1f/appengine/findit/dto/list_of_basestring.py

Status: Fixed (was: Assigned)

Sign in to add a comment